Functionality to retrieve Service Reference from Service#1044
Merged
tcormackMW merged 10 commits intodevelopmentfrom Oct 11, 2024
Merged
Functionality to retrieve Service Reference from Service#1044tcormackMW merged 10 commits intodevelopmentfrom
tcormackMW merged 10 commits intodevelopmentfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1044 +/- ##
===============================================
- Coverage 88.42% 88.39% -0.04%
===============================================
Files 252 253 +1
Lines 12155 12175 +20
===============================================
+ Hits 10748 10762 +14
- Misses 1407 1413 +6
|
jeffdiclemente
requested changes
Oct 9, 2024
Member
jeffdiclemente
left a comment
There was a problem hiding this comment.
please add a RFC for this to the rfcs repo. Thanks!
Burgch
reviewed
Oct 9, 2024
Contributor
Burgch
left a comment
There was a problem hiding this comment.
Looking good, thanks Toby! +1 to Jeff's comments too :)
carneyweb
reviewed
Oct 9, 2024
carneyweb
approved these changes
Oct 9, 2024
jeffdiclemente
approved these changes
Oct 11, 2024
Member
jeffdiclemente
left a comment
There was a problem hiding this comment.
I think there is one testpoint missing that would be useful to lockdown the behavior of a ServiceReference. Other than that, LGTM and if you agree with me, I don't need to re-review after adding another testpoint.
RobertLauferElektrobit
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jul 24, 2025
…vices#1044) --------- Co-authored-by: Toby Cormack <tcormack@mathworks.com>
jeffdiclemente
pushed a commit
that referenced
this pull request
Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.