Remove deadlock in config notification#1040
Merged
tcormackMW merged 5 commits intodevelopmentfrom Sep 23, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1040 +/- ##
===============================================
- Coverage 88.40% 88.39% -0.01%
===============================================
Files 252 252
Lines 12156 12155 -1
===============================================
- Hits 10746 10745 -1
Misses 1410 1410
|
Burgch
requested changes
Sep 13, 2024
Contributor
Burgch
left a comment
There was a problem hiding this comment.
Looks great, thanks Toby!
jeffdiclemente
approved these changes
Sep 13, 2024
Member
jeffdiclemente
left a comment
There was a problem hiding this comment.
LGTM, once the other comments are addressed.
added 2 commits
September 13, 2024 13:53
's comment
RobertLauferElektrobit
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jul 28, 2025
* added test to verify that update call from inside modified no longer causes deadlock * memory leaks... no idea why they are happening but 99% sure this is a false positive * fix false leak * respond to jeff comments * respond to conor 's comment --------- Co-authored-by: Toby Cormack <tcormack@mathworks.com>
jeffdiclemente
added a commit
that referenced
this pull request
Jul 29, 2025
* added test to verify that update call from inside modified no longer causes deadlock * memory leaks... no idea why they are happening but 99% sure this is a false positive * fix false leak * respond to jeff comments * respond to conor 's comment --------- Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com> Co-authored-by: Toby Cormack <tcormack@mathworks.com> Co-authored-by: Jeff DiClemente <jeffdiclemente@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the 'ordering lock' that was doing little other than causing Deadlocks
Before change, the added test case causes deadlock, after change it does not