Skip to content

Functionality to print anymap to a compilable c++ format#1013

Merged
tcormackMW merged 7 commits intodevelopmentfrom
anyMapToCppFile
Jun 28, 2024
Merged

Functionality to print anymap to a compilable c++ format#1013
tcormackMW merged 7 commits intodevelopmentfrom
anyMapToCppFile

Conversation

@tcormackMW
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread framework/include/cppmicroservices/Any.h
Comment thread framework/include/cppmicroservices/Any.h
Comment thread framework/include/cppmicroservices/Any.h
Comment thread framework/include/cppmicroservices/Any.h
Comment thread framework/include/cppmicroservices/Any.h
Comment thread framework/test/gtest/AnyMapTest.cpp Outdated
Comment thread framework/test/gtest/AnyMapTest.cpp
Comment thread framework/test/gtest/AnyMapTest.cpp
Comment thread framework/test/gtest/AnyMapTest.cpp Outdated
Comment thread framework/test/gtest/AnyMapTest.cpp Outdated
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Comment thread framework/test/gtest/AnyMapTest.cpp Outdated
Comment thread framework/test/gtest/AnyMapTest.cpp
Comment thread framework/test/gtest/AnyMapTest.cpp
@tcormackMW tcormackMW self-assigned this Jun 25, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 64.93506% with 54 lines in your changes missing coverage. Please review.

Project coverage is 88.48%. Comparing base (899530e) to head (cdec88b).
Report is 4 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #1013      +/-   ##
===============================================
+ Coverage        84.93%   88.48%   +3.55%     
===============================================
  Files              133      242     +109     
  Lines             7527    11880    +4353     
===============================================
+ Hits              6393    10512    +4119     
- Misses            1134     1368     +234     
Files Coverage Δ
framework/include/cppmicroservices/AnyMap.h 73.33% <ø> (ø)
framework/src/util/AnyMap.cpp 86.95% <83.33%> (-0.28%) ⬇️
framework/src/util/Any.cpp 81.31% <50.00%> (-16.99%) ⬇️
framework/include/cppmicroservices/Any.h 86.30% <64.13%> (-10.68%) ⬇️

... and 128 files with indirect coverage changes

Copy link
Copy Markdown
Contributor

@carneyweb carneyweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the one missing map_type (if I read the code right), and we can chat about whether the types and enums should be fully qualified or not.

Comment thread framework/include/cppmicroservices/Any.h Outdated
Comment thread framework/src/util/AnyMap.cpp
@tcormackMW tcormackMW requested a review from carneyweb June 28, 2024 13:56
@tcormackMW tcormackMW merged commit aa851d7 into development Jun 28, 2024
@tcormackMW tcormackMW deleted the anyMapToCppFile branch June 28, 2024 18:01
RobertLauferElektrobit pushed a commit to insi-eb/CppMicroServices-cpp14 that referenced this pull request Jul 24, 2025
jeffdiclemente pushed a commit that referenced this pull request Jul 25, 2025
Co-authored-by: tcormackMW <113473781+tcormackMW@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants