Update LogService class in CppMicroServices by architapruthi · Pull Request #1009 · CppMicroServices/CppMicroServices

architapruthi · 2024-05-28T07:21:21Z

The current CppMicroServices LogService API and implementation that we ship with CppMicroServices does not confirm to the latest LogService OSGi spec (https://docs.osgi.org/specification/osgi.core/8.0.0/service.log.html).

Hence, to support latest features and classes, we are updating LogService class, which confirms to OSGi spec 8.

More information can be found out in the following RFC:
CppMicroServices/rfcs#21

Signed-off-by: The MathWorks, Inc.
architap@mathworks.com

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

codecov · 2024-05-31T09:05:50Z

Codecov Report

Attention: Patch coverage is 90.94203% with 25 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (9c87715) to head (d2ddd10).
Report is 2 commits behind head on development.

Files with missing lines	Patch %	Lines
compendium/LogServiceImpl/src/LogServiceImpl.cpp	78.78%	7 Missing ⚠️
compendium/LogServiceImpl/src/LoggerImpl.cpp	96.02%	7 Missing ⚠️
...ompendium/LogServiceImpl/src/LoggerFactoryImpl.cpp	50.00%	4 Missing ⚠️
compendium/ConfigurationAdmin/src/CMLogger.cpp	83.33%	2 Missing ⚠️
compendium/DeclarativeServices/src/SCRLogger.cpp	83.33%	2 Missing ⚠️
framework/src/util/CFRLogger.cpp	87.50%	2 Missing ⚠️
compendium/LogServiceImpl/src/LogServiceImpl.hpp	93.33%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #1009      +/-   ##
===============================================
+ Coverage        88.29%   88.40%   +0.10%     
===============================================
  Files              248      252       +4     
  Lines            11931    12156     +225     
===============================================
+ Hits             10535    10746     +211     
- Misses            1396     1410      +14

Files with missing lines	Coverage Δ
...ompendium/LogServiceImpl/src/LoggerFactoryImpl.hpp	`100.00% <100.00%> (ø)`
compendium/LogServiceImpl/src/LoggerImpl.hpp	`100.00% <100.00%> (ø)`
framework/src/bundle/CoreBundleContext.cpp	`95.09% <100.00%> (-0.05%)`	⬇️
compendium/LogServiceImpl/src/LogServiceImpl.hpp	`93.75% <93.33%> (-6.25%)`	⬇️
compendium/ConfigurationAdmin/src/CMLogger.cpp	`90.16% <83.33%> (-1.68%)`	⬇️
compendium/DeclarativeServices/src/SCRLogger.cpp	`93.44% <83.33%> (-2.48%)`	⬇️
framework/src/util/CFRLogger.cpp	`90.90% <87.50%> (+18.97%)`	⬆️
...ompendium/LogServiceImpl/src/LoggerFactoryImpl.cpp	`50.00% <50.00%> (ø)`
compendium/LogServiceImpl/src/LogServiceImpl.cpp	`78.57% <78.78%> (-21.43%)`	⬇️
compendium/LogServiceImpl/src/LoggerImpl.cpp	`96.02% <96.02%> (ø)`

... and 1 file with indirect coverage changes

github-actions

clang-tidy made some suggestions

…icroServices into logService

github-actions

clang-tidy made some suggestions

github-actions

clang-tidy made some suggestions

jeffdiclemente · 2024-09-05T12:45:01Z

@carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks.

carneyweb · 2024-09-09T18:24:43Z

Sorry for the delay. Looks good. - Mike.

…

On Sep 5, 2024 at 8:45 AM -0400, Jeff DiClemente ***@***.***>, wrote: @carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: ***@***.***>

* Update LogService class --------- Co-authored-by: Archita P <architap@mathworks.com>

* Update LogService class in CppMicroServices (#1009) * Update LogService class --------- Co-authored-by: Archita P <architap@mathworks.com> * adapt for C++14 --------- Co-authored-by: architapruthi <architapruthi92@gmail.com> Co-authored-by: Archita P <architap@mathworks.com>

Update LogService class

6482fe3

architapruthi requested a review from jeffdiclemente May 28, 2024 07:21

architapruthi self-assigned this May 28, 2024

architapruthi requested a review from kkumar45 May 28, 2024 07:22

github-actions bot reviewed May 28, 2024

View reviewed changes

architapruthi marked this pull request as draft May 28, 2024 10:31

kkumar45 reviewed May 31, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp Outdated

kkumar45 reviewed May 31, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp Outdated

Resolve Github action comments

ce326b1

github-actions bot reviewed May 31, 2024

View reviewed changes

kkumar45 reviewed May 31, 2024

View reviewed changes

Comment thread compendium/LogServiceImpl/src/LoggerImpl.hpp Outdated

Comment thread compendium/LogServiceImpl/src/LoggerImpl.hpp Outdated

Comment thread compendium/LogServiceImpl/src/LoggerImpl.cpp Outdated

Comment thread compendium/LogServiceImpl/src/LoggerImpl.cpp Outdated

Address feedback

a9ba09e

architapruthi requested review from carneyweb and tcormackMW June 5, 2024 05:38

jeffdiclemente marked this pull request as ready for review June 5, 2024 11:27

carneyweb requested changes Jun 6, 2024

View reviewed changes

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp Outdated

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp Outdated

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp Outdated

Incorporating feedback

31319a8

jeffdiclemente requested changes Jun 14, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp Outdated

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp Outdated

jeffdiclemente reviewed Jun 14, 2024

View reviewed changes

Comment thread compendium/LogServiceImpl/test/TestLogService.cpp

tcormackMW reviewed Jun 14, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp Outdated

Comment thread compendium/LogServiceImpl/src/Activator.cpp Outdated

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp Outdated

jeffdiclemente requested changes Jun 17, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/LogService.hpp Outdated

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp Outdated

Comment thread compendium/LogService/include/cppmicroservices/logservice/LoggerFactory.hpp Outdated

Archita P added 2 commits June 18, 2024 16:37

Incorporated feedbacks

0e0321e

Modified test

c64af4b

github-actions bot reviewed Jun 19, 2024

View reviewed changes

Comment thread compendium/LogServiceImpl/test/TestLogService.cpp

jeffdiclemente requested review from carneyweb, jeffdiclemente, kkumar45 and tcormackMW June 26, 2024 10:53

jeffdiclemente requested changes Jun 26, 2024

View reviewed changes

Archita P added 3 commits July 17, 2024 10:14

Address feedback

e8b4bc9

Merge branch 'logService' of https://github.com/CppMicroServices/CppM…

d31d109

…icroServices into logService

Update Logger.hpp file

d6da11a

github-actions bot reviewed Jul 17, 2024

View reviewed changes

Comment thread framework/test/gtest/CFRLoggerTest.cpp

Comment thread framework/test/gtest/CFRLoggerTest.cpp

Comment thread framework/test/gtest/CFRLoggerTest.cpp

Comment thread framework/test/gtest/CFRLoggerTest.cpp

Comment thread framework/test/gtest/CFRLoggerTest.cpp

jeffdiclemente requested changes Jul 17, 2024

View reviewed changes

Comment thread framework/src/util/CFRLogger.cpp Outdated

jeffdiclemente requested changes Jul 18, 2024

View reviewed changes

Comment thread framework/src/util/CFRLogger.cpp

Comment thread framework/src/util/CFRLogger.cpp

Comment thread compendium/DeclarativeServices/src/SCRLogger.cpp

Comment thread compendium/DeclarativeServices/src/SCRLogger.cpp

Archita P added 2 commits July 22, 2024 11:51

Modifications

762d7ee

Modifying CFRLogger

e69303e

BrianWeed reviewed Jul 26, 2024

View reviewed changes

Comment thread framework/src/util/CFRLogger.cpp Outdated

jeffdiclemente reviewed Jul 26, 2024

View reviewed changes

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp Outdated

Archita P added 3 commits July 29, 2024 10:53

Modifications

b194f5c

Reverting one change

4886d62

Making required change

e34fe09

jeffdiclemente approved these changes Jul 31, 2024

View reviewed changes

tcormackMW reviewed Jul 31, 2024

View reviewed changes

Comment thread compendium/LogServiceImpl/src/LogServiceImpl.cpp Outdated

tcormackMW reviewed Aug 1, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp

Reducing code redundancy

b205784

jeffdiclemente approved these changes Aug 5, 2024

View reviewed changes

Archita P and others added 3 commits August 21, 2024 18:33

Running clang-format

7695495

Running clang-format

8f1c51d

Merge branch 'development' into logService

d2ddd10

github-actions bot reviewed Sep 3, 2024

View reviewed changes

Comment thread compendium/LogService/include/cppmicroservices/logservice/Logger.hpp

carneyweb approved these changes Sep 9, 2024

View reviewed changes

jeffdiclemente merged commit 070fd93 into development Sep 11, 2024

jeffdiclemente deleted the logService branch September 11, 2024 16:38

RobertLauferElektrobit pushed a commit to insi-eb/CppMicroServices-cpp14 that referenced this pull request Jul 25, 2025

Update LogService class in CppMicroServices (CppMicroServices#1009)

8909702

* Update LogService class --------- Co-authored-by: Archita P <architap@mathworks.com>

RobertLauferElektrobit mentioned this pull request Jul 25, 2025

701 Update LogService class in CppMicroServices (#1009) #1163

Merged

Conversation

architapruthi commented May 28, 2024

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented May 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

codecov bot commented May 31, 2024 •

edited

Loading