Conversation
5c60600 to
c1b0095
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #107 +/- ##
==========================================
- Coverage 69.03% 68.98% -0.06%
==========================================
Files 30 30
Lines 2781 2789 +8
==========================================
+ Hits 1920 1924 +4
- Misses 861 865 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
RalfG
approved these changes
Nov 18, 2024
This was referenced Nov 18, 2024
RalfG
added a commit
that referenced
this pull request
Nov 19, 2024
Remove numpy version pin (should have been part of #107)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed
io.idxml: Make pyOpenMS an optional dependency, working around ImportError with pyOpenMS version 3.2.0 on Windows when PyArrow was imported OpenMS/OpenMS#7600 for now. Foridxmlsupport, install psm_utils with theidxmlextra dependencies.