Skip to content

Move diagnostics for orphaned observable property attributes to analyzer#434

Merged
Sergio0694 merged 2 commits intomainfrom
dev/orphaned-fields-analyzer
Sep 10, 2022
Merged

Move diagnostics for orphaned observable property attributes to analyzer#434
Sergio0694 merged 2 commits intomainfrom
dev/orphaned-fields-analyzer

Conversation

@Sergio0694
Copy link
Copy Markdown
Member

Closes #426

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tested code with current supported SDKs
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

@Sergio0694 Sergio0694 added optimization ☄ Performance or memory usage improvements mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit labels Sep 10, 2022
@Sergio0694 Sergio0694 force-pushed the dev/orphaned-fields-analyzer branch from 4272288 to 7f2773a Compare September 10, 2022 00:45
@Sergio0694 Sergio0694 force-pushed the dev/orphaned-fields-analyzer branch from 7f2773a to b8749fe Compare September 10, 2022 00:48
@Sergio0694 Sergio0694 merged commit 5876242 into main Sep 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the dev/orphaned-fields-analyzer branch September 10, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mvvm-toolkit 🧰 Issues/PRs for the MVVM Toolkit optimization ☄ Performance or memory usage improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move diagnostis unrelated to generation to diagnostic analyzers

1 participant