Consolidated ProjectHeads and supporting infrastructure#360
Merged
michael-hawker merged 65 commits intomainfrom Feb 21, 2023
Merged
Consolidated ProjectHeads and supporting infrastructure#360michael-hawker merged 65 commits intomainfrom
michael-hawker merged 65 commits intomainfrom
Conversation
Member
|
Hmm, wasm failing with the dotnet/sdk#30361 error is concerning: https://github.com/CommunityToolkit/Labs-Windows/actions/runs/4089001610/jobs/7051284264#step:5:28 |
Update WindowsAppSDK version and MSTest tools Add properties to allow tests to run on 1.2.x, see microsoft/testfx#1127 Remove solution files from experiments Add bat file to copy heads and run slngen Tested locally running all heads and tests for an experiment
…path Wasn't being built as was excluded from wildcard in solution generator
…ith diagnostics Fix diagnostic flag detection
841b02a to
aa01d88
Compare
…/CommunityToolkit/Labs-Windows into refactor/generated-project-heads
Member
|
This PR should be good to go once the slngen PR merges: microsoft/slngen#455 (and we take that version here) See private check here build: https://github.com/CommunityToolkit/Labs-Windows/actions/runs/4196634011 |
Member
michael-hawker
left a comment
There was a problem hiding this comment.
Couple of quick questions about props file moves, but once-over looks good.
Should hopefully resolve CI issues from microsoft/slngen#453 and its initial fix
michael-hawker
approved these changes
Feb 21, 2023
Member
michael-hawker
left a comment
There was a problem hiding this comment.
Everything is building now, if we missed anything we'll fix it forward. Let's go!
This was referenced Feb 23, 2023
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
…lkit#360) * Moved project heads to common folder * Fixed broken reference to props file * Fix broken path references * Fixed broken file references * Fixed broken path * Move asset references to props file * Consolidated ProjectHeads and supporting infrastructure * Migrating projects to new infra * Migrating files to new infra * Added missing assemblyname and rootnamespace declaration * Fixed building WinAppSdk * Fixed build errors for UWP under "All" solution * Fixed working directory for UseTargetFrameworks.ps1 * Switch GenerateSingleSampleHeads.ps1 to use dotnet templating tool Update WindowsAppSDK version and MSTest tools Add properties to allow tests to run on 1.2.x, see microsoft/testfx#1127 Remove solution files from experiments Add bat file to copy heads and run slngen Tested locally running all heads and tests for an experiment * Update folder for linux CI build and Codespaces to WASM project * Clean-up and re-work build script for testing the project template * Use expanded form for environment variables everywhere * Use repo root path for script when in working directory of template * Use github syntax for environment variable for path, see actions/runner-images#1794 * Re-work path structure for project template test in ci * Setup paths again to use full path into GenerateSingleSampleHeads script * Fixed comment referencing outdated file name * Use absolute path for project references in the "All" solution * Removed leading directory separator on generated path * Update slngen to fix build issues with not finding SDK due to global.json See details in microsoft/slngen#453 * Add flag to build to enable easily getting diagnostics from tools * Clean-up labels and conditions for diagnostics * Add COREHOST_TRACE diagnostics for dotnet * Move conditional for COREHOST_TRACE into step * Just have COREHOST_TRACE defined at top * Add calling dotnet --info * Fixed missing markdown/cs files. Changed "Experiment" to "ToolkitComponent" * Revert initial work renaming Experiment to Component. * Fixed markdown exclude path * Moved project out of double nested folder * Removed restored files that should have been deleted * Move SourceGenerators.Tests project up a folder and fix in build.yml path Wasn't being built as was excluded from wildcard in solution generator * Fixed path for test output * Improved and shortened project names * Rename LabsUITestMethod to UIThreadTestMethod * Renamed to CommunityToolkit.Tooling.TestGen * New names for UITestMethodAttribute and UITestMethodGenerator * Fixed incorrect namespace * Fixed a bad find/replace * Renamed "all" component heads and App/Test shared projects * Added "App" to app head names * Fixed runtime error * Move SourceGenerators.Tests project up a folder and fix in build.yml path Wasn't being built as was excluded from wildcard in solution generator * Fixed path for test output * Improved and shortened project names * Rename LabsUITestMethod to UIThreadTestMethod * Renamed to CommunityToolkit.Tooling.TestGen * New names for UITestMethodAttribute and UITestMethodGenerator * Renamed "all" component heads and App/Test shared projects * Added "App" to app head names * Turn off diagnostics for our powershell scripts as slngen has error with diagnostics Fix diagnostic flag detection * Enable git long path support for the clean operation * Update microsoft/setup-msbuild github action * Cleaned up moved files that weren't deleted properly * Update slngen to 9.5.4 Should hopefully resolve CI issues from microsoft/slngen#453 and its initial fix --------- Co-authored-by: michael-hawker <24302614+michael-hawker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #358
This PR makes several improvements:
./common/ProjectHeads/./common/MultiTarget/./Platformshave been moved to./common/ProjectHeads/AllComponents/./common/ProjectHeads/SingleComponent/../common/ProjectHeads/GenerateSingleSampleHeads.ps1has been added to copy the single-component heads into a component folder and update the names to reflect the component../common/ToolkitComponent.SampleProject.props../common/ToolkitComponent.SourceProject.props.This needs #350 to be merged upstream before it can be completed