Accommodate WinUI 2/3 dependencies per-experiment#139
Merged
michael-hawker merged 10 commits intomainfrom Jun 6, 2022
Merged
Conversation
Member
|
FYI, even after the toolkit merges namespaces, we'll still need to pivot on UWP vs. WinUI 3, and do similar things for other packages like the Behaviors (at least there I think they may use the same namespace?). It'll just remove the need for the namespace/control reference trick. Unless you meant something else by 'placeholder props' |
michael-hawker
requested changes
Jun 3, 2022
Member
michael-hawker
left a comment
There was a problem hiding this comment.
This is going to be great! Have some comments/suggestions to improvements on instructions.
Member
Author
This refers to the empty props files where the user can add PackageReferences |
Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
Arlodotexe
commented
Jun 3, 2022
michael-hawker
approved these changes
Jun 6, 2022
Member
michael-hawker
left a comment
There was a problem hiding this comment.
Yeah, I like this a lot better, now we're just adding two files per project vs. 3 (one of which was to be ignored). Seems simpler. 🎉
Martin1994
pushed a commit
to Martin1994/Labs-Windows
that referenced
this pull request
Sep 2, 2023
* Added props files for WinUI 2 and WinUI 3 dependencies * Fixed an issue where WinUI version had to be swapped for Uwp or WinAppSdk to get dependencies * Fixed UWP TargetFramework check * Update template/lab/src/Labs.WinUI.Dependencies.props Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com> * Fixed invalid WinAppSdk check * Rename UseWinUI to WinUIMajorVersion * Added note for NS2.0 dependencies * Update labs/CanvasLayout/src/Dependencies.WinUI3.props * Moved lab WinUI dependency data to existing Uno props file Co-authored-by: Michael Hawker MSFT (XAML Llama) <24302614+michael-hawker@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #132
This PR adds placeholder props files in all library projects that allow for easy adding of WinUI 2 / 3 dependenies under Uno / Native.
This was tested with the WrapPanel in the Windows Community Toolkit, and works under UWP/WinAppSDK and Android/Wasm via WinUI 2 / Android via WinUI 3.
Wasm under WinUI 3 wasn't testable due to #77.
Because of the differences in namespaces between the WinUI 2 WCT vs the WinUI 3 WCT, a small workaround had to be used, seen below along with example ProjectReferences.
This workaround can be removed when we finish syncing the namespaces in both packages.