Skip to content

Fix TypeScript AppHost validation restore#1371

Merged
aaronpowell merged 4 commits into
CommunityToolkit:update-aspire-13.4.0-preview.1.26275.2-8bac32c5cb721fb5from
sebastienros:sebros/ts-apphost-cli-restore
May 27, 2026
Merged

Fix TypeScript AppHost validation restore#1371
aaronpowell merged 4 commits into
CommunityToolkit:update-aspire-13.4.0-preview.1.26275.2-8bac32c5cb721fb5from
sebastienros:sebros/ts-apphost-cli-restore

Conversation

@sebastienros

@sebastienros sebastienros commented May 27, 2026

Copy link
Copy Markdown
Contributor

Targets #1359.\n\nThis updates the TypeScript AppHost validation path to rely on checked-in local project references instead of packing integrations into a temporary NuGet source. CI now installs the Aspire CLI from the staging channel, while deriving the expected CLI version from the repo's AspireVersion and verifying the installed CLI matches that 13.4.0 line.

sebastienros and others added 4 commits May 27, 2026 11:13
Install the matching Aspire CLI version in CI and stop rewriting TypeScript AppHost package references during validation so checked-in project references are used directly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Install the staging Aspire CLI channel in CI so TypeScript AppHost validation uses the 13.4.0 CLI instead of a later dev build or an exact package version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Install the Aspire CLI from the staging channel while deriving the expected CLI version from the repository AspireVersion so CI fails if staging does not match the test branch line.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aaronpowell aaronpowell merged commit a29062d into CommunityToolkit:update-aspire-13.4.0-preview.1.26275.2-8bac32c5cb721fb5 May 27, 2026
4 of 5 checks passed
aaronpowell added a commit that referenced this pull request May 28, 2026
* Update Aspire version to 13.4.0-preview.1.26275.2

Updated the following:
- Directory.Build.props: Updated AspireMajorVersion, AspireVersion, and cleared AspirePreviewSuffix
- All 52 AppHost .csproj files: Updated Aspire.AppHost.Sdk version in Project Sdk attribute
- All 39 aspire.config.json files: Updated sdk.version field in TypeScript AppHost configurations

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix Aspire AppHost build compatibility on .NET 10

Disable Aspire SDK PickBestRid path and align central package versions required by Aspire 13.4 preview.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Missing files from commit

* Removing obsolete and unused Parameter

* Bumping the aspire cli to dev

* Adding aspire doctor to the jobs in a failed test run

* Moving to mts from ts file extension

* updating path to the aspire module

* Updating to the latest nightly and fixing ts paths

Set the wrong paths initially, I blame fowler

* Bumping the toolkit version

* Fix TypeScript AppHost validation restore (#1371)

* Fix TypeScript AppHost validation restore

Install the matching Aspire CLI version in CI and stop rewriting TypeScript AppHost package references during validation so checked-in project references are used directly.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Use staging Aspire CLI for tests

Install the staging Aspire CLI channel in CI so TypeScript AppHost validation uses the 13.4.0 CLI instead of a later dev build or an exact package version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Revert "Use staging Aspire CLI for tests"

This reverts commit 8639daf.

* Use staging Aspire CLI with version check

Install the Aspire CLI from the staging channel while deriving the expected CLI version from the repository AspireVersion so CI fails if staging does not match the test branch line.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix failing Aspire 13.4 validation tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address Aspire package review comments

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Stabilize failing CI tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Skip Nx install during TypeScript validation

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Aaron Powell <me@aaron-powell.com>
Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants