Fix TypeScript AppHost validation restore#1371
Merged
aaronpowell merged 4 commits intoMay 27, 2026
Conversation
Install the matching Aspire CLI version in CI and stop rewriting TypeScript AppHost package references during validation so checked-in project references are used directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Install the staging Aspire CLI channel in CI so TypeScript AppHost validation uses the 13.4.0 CLI instead of a later dev build or an exact package version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This reverts commit 8639daf.
Install the Aspire CLI from the staging channel while deriving the expected CLI version from the repository AspireVersion so CI fails if staging does not match the test branch line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
a29062d
into
CommunityToolkit:update-aspire-13.4.0-preview.1.26275.2-8bac32c5cb721fb5
4 of 5 checks passed
aaronpowell
added a commit
that referenced
this pull request
May 28, 2026
* Update Aspire version to 13.4.0-preview.1.26275.2 Updated the following: - Directory.Build.props: Updated AspireMajorVersion, AspireVersion, and cleared AspirePreviewSuffix - All 52 AppHost .csproj files: Updated Aspire.AppHost.Sdk version in Project Sdk attribute - All 39 aspire.config.json files: Updated sdk.version field in TypeScript AppHost configurations Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix Aspire AppHost build compatibility on .NET 10 Disable Aspire SDK PickBestRid path and align central package versions required by Aspire 13.4 preview. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Missing files from commit * Removing obsolete and unused Parameter * Bumping the aspire cli to dev * Adding aspire doctor to the jobs in a failed test run * Moving to mts from ts file extension * updating path to the aspire module * Updating to the latest nightly and fixing ts paths Set the wrong paths initially, I blame fowler * Bumping the toolkit version * Fix TypeScript AppHost validation restore (#1371) * Fix TypeScript AppHost validation restore Install the matching Aspire CLI version in CI and stop rewriting TypeScript AppHost package references during validation so checked-in project references are used directly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Use staging Aspire CLI for tests Install the staging Aspire CLI channel in CI so TypeScript AppHost validation uses the 13.4.0 CLI instead of a later dev build or an exact package version. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Revert "Use staging Aspire CLI for tests" This reverts commit 8639daf. * Use staging Aspire CLI with version check Install the Aspire CLI from the staging channel while deriving the expected CLI version from the repository AspireVersion so CI fails if staging does not match the test branch line. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix failing Aspire 13.4 validation tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Address Aspire package review comments Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Stabilize failing CI tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Skip Nx install during TypeScript validation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Aaron Powell <me@aaron-powell.com> Co-authored-by: Sébastien Ros <sebastienros@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets #1359.\n\nThis updates the TypeScript AppHost validation path to rely on checked-in local project references instead of packing integrations into a temporary NuGet source. CI now installs the Aspire CLI from the staging channel, while deriving the expected CLI version from the repo's AspireVersion and verifying the installed CLI matches that 13.4.0 line.