Add polyglot exports for kurrentdb#1187
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1187Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1187" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot export coverage for the KurrentDB hosting integration and introduces a matching TypeScript ValidationAppHost under the playground to exercise the generated exports and resource property exposure.
Changes:
- Annotate
KurrentDBResourceand relevant builder extension methods with[AspireExport](includingExposeProperties = trueon the resource). - Add a new TypeScript ValidationAppHost (tsconfig/package files, apphost.ts, run profile, Aspire settings) for KurrentDB.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.KurrentDB/KurrentDBResource.cs | Adds AspireExport exposure for KurrentDB resource properties and suppresses the experimental warning. |
| src/CommunityToolkit.Aspire.Hosting.KurrentDB/KurrentDBBuilderExtensions.cs | Exports KurrentDB builder APIs (addKurrentDB, withDataVolume, withDataBindMount) for polyglot usage and suppresses the experimental warning. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/tsconfig.json | Adds TS compiler configuration for the new ValidationAppHost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/package.json | Defines the Node/TypeScript ValidationAppHost package and scripts. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/package-lock.json | Locks dependencies for reproducible ValidationAppHost installs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/apphost.ts | Exercises exported APIs and property exposure for KurrentDB in TypeScript. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/apphost.run.json | Adds run profile configuration for the ValidationAppHost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/.aspire/settings.json | Configures Aspire settings for running the TS ValidationAppHost with the KurrentDB package. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.KurrentDB/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+4
to
+5
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
| "rootDir": "." | ||
| }, | ||
| "include": ["apphost.ts", ".modules/**/*.ts", ".modules/**/*.d.ts"], | ||
| "exclude": ["node_modules"] |
Comment on lines
+10
to
+11
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
409f134 to
aea09f7
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aaronpowell
added a commit
that referenced
this pull request
Apr 1, 2026
Squash merge of #1187 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for kurrentdb.