Add polyglot exports for papercutsmtp#1186
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1186Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1186" |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds polyglot (TypeScript) export coverage for the Papercut SMTP hosting integration by annotating the C# API/resources for export and introducing a matching TypeScript ValidationAppHost under playground/.
Changes:
- Add
[AspireExport]annotations to the Papercut SMTP hosting extension method and container resource (including property exposure). - Add a TypeScript ValidationAppHost (apphost + tsconfig + npm manifests + Aspire settings/run profile) for export validation.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.PapercutSmtp/PapercutSmtpHostingExtension.cs | Adds AspireExport to AddPapercutSmtp and updates XML docs. |
| src/CommunityToolkit.Aspire.Hosting.PapercutSmtp/PapercutSmtpContainerResource.cs | Adds AspireExport(ExposeProperties=true) and improves constructor param docs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/apphost.ts | TypeScript apphost that exercises the exported addPapercutSmtp API and resource property access. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/tsconfig.json | TS compiler configuration for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/package.json | NPM package manifest for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/package-lock.json | Lockfile for the validation apphost dependencies. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/apphost.run.json | Aspire run profile settings for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/.aspire/settings.json | Aspire polyglot settings referencing the Papercut SMTP package. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.PapercutSmtp/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+4
to
+5
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
| int? smtpPort = null) | ||
| { | ||
| ArgumentNullException.ThrowIfNull("Service name must be specified.", nameof(name)); | ||
| ArgumentNullException.ThrowIfNull(name, nameof(name)); |
Comment on lines
+1
to
+2
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
8f9b133 to
69ba85a
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aaronpowell
added a commit
that referenced
this pull request
Apr 1, 2026
Squash merge of #1186 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for papercutsmtp.