Add polyglot exports for meilisearch#1185
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1185Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1185" |
f893e51 to
1904a1c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Aspire polyglot export metadata for the Meilisearch hosting integration and introduces a TypeScript ValidationAppHost sample to validate the generated TypeScript surface.
Changes:
- Annotate
MeilisearchResourceand Meilisearch builder extension methods with[AspireExport](includingExposeProperties = trueon the resource). - Mark
AddMeilisearch’snameparameter with[ResourceName]for consistent resource naming semantics. - Add a new TypeScript polyglot
ValidationAppHost(tsconfig/package manifests, run profile, and .aspire settings).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CommunityToolkit.Aspire.Hosting.Meilisearch/MeilisearchResource.cs | Adds [AspireExport(ExposeProperties = true)] and ASPIREATS001 suppression for polyglot export/property exposure. |
| src/CommunityToolkit.Aspire.Hosting.Meilisearch/MeilisearchBuilderExtensions.cs | Adds [AspireExport] to exported APIs, adds [ResourceName], and suppresses ASPIREATS001 for experimental exports. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/tsconfig.json | TypeScript compiler configuration for the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/package.json | NPM package manifest/scripts for running/building the validation apphost. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/package-lock.json | Locked dependency graph for reproducible installs. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/apphost.ts | Validation apphost exercising exported APIs and exposed resource properties. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/apphost.run.json | Local run profile configuration for Aspire. |
| playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/.aspire/settings.json | Aspire settings pointing at the TS apphost and package version. |
Files not reviewed (1)
- playground/polyglot/TypeScript/CommunityToolkit.Aspire.Hosting.Meilisearch/ValidationAppHost/package-lock.json: Language not supported
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+1
to
+2
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Comment on lines
+10
to
+11
| #pragma warning disable ASPIREATS001 // AspireExport is experimental | ||
|
|
Comment on lines
+29
to
+34
| const meilisearchResource = await meilisearch; | ||
| const _primaryEndpoint = await meilisearchResource.primaryEndpoint.get(); | ||
| const _host = await meilisearchResource.host.get(); | ||
| const _port = await meilisearchResource.port.get(); | ||
| const _uri = await meilisearchResource.uriExpression.get(); | ||
| const _connectionString = await meilisearchResource.connectionStringExpression.get(); |
Contributor
Minimum allowed line rate is |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
5029041 to
a843e44
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
aaronpowell
added a commit
that referenced
this pull request
Apr 1, 2026
Squash merge of #1185 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds AspireExport coverage and a matching TypeScript validation apphost for meilisearch.