Skip to content

[Training Node] algo support, grad acc, optional grad ckpt#9015

Merged
comfyanonymous merged 13 commits intoComfy-Org:masterfrom
KohakuBlueleaf:training-node-impr
Jul 24, 2025
Merged

[Training Node] algo support, grad acc, optional grad ckpt#9015
comfyanonymous merged 13 commits intoComfy-Org:masterfrom
KohakuBlueleaf:training-node-impr

Conversation

@KohakuBlueleaf
Copy link
Copy Markdown
Contributor

@KohakuBlueleaf KohakuBlueleaf commented Jul 23, 2025

As title, this PR propose following updates of lora training node:

  1. support algorithm selection (currently support LoRA/LoHa/LoKr/OFT)
  2. support optional gradient checkpointing LoRA training QoL improvements: UI progress bar, deterministic seeding, make gradient checkpointing optional #8668
  3. support gradient accumulation for simulating large batch size

@KohakuBlueleaf
Copy link
Copy Markdown
Contributor Author

May have conflict with #8668
If 8668 is ok to merge than I prefer to merge 8668 first than I resolve conflict afterward

@comfyanonymous comfyanonymous merged commit eb2f78b into Comfy-Org:master Jul 24, 2025
6 checks passed
SurpassHR pushed a commit to SurpassHR/ComfyUI-Playground that referenced this pull request Jul 24, 2025
…#9015)

* Add factorization utils for lokr

* Add lokr train impl

* Add loha train impl

* Add adapter map for algo selection

* Add optional grad ckpt and algo selection

* Update __init__.py

* correct key name for loha

* Use custom fwd/bwd func and better init for loha

* Support gradient accumulation

* Fix bugs of loha

* use more stable init

* Add OFT training

* linting
bigcat88 added a commit to bigcat88/ComfyUI that referenced this pull request Jul 24, 2025
Vander-Bilt pushed a commit to Vander-Bilt/ComfyUI that referenced this pull request Aug 26, 2025
…#9015)

* Add factorization utils for lokr

* Add lokr train impl

* Add loha train impl

* Add adapter map for algo selection

* Add optional grad ckpt and algo selection

* Update __init__.py

* correct key name for loha

* Use custom fwd/bwd func and better init for loha

* Support gradient accumulation

* Fix bugs of loha

* use more stable init

* Add OFT training

* linting
toxicwind pushed a commit to toxicwind/ComfyUI that referenced this pull request Oct 12, 2025
…#9015)

* Add factorization utils for lokr

* Add lokr train impl

* Add loha train impl

* Add adapter map for algo selection

* Add optional grad ckpt and algo selection

* Update __init__.py

* correct key name for loha

* Use custom fwd/bwd func and better init for loha

* Support gradient accumulation

* Fix bugs of loha

* use more stable init

* Add OFT training

* linting
adlerfaulkner pushed a commit to LucaLabsInc/ComfyUI that referenced this pull request Oct 16, 2025
…#9015)

* Add factorization utils for lokr

* Add lokr train impl

* Add loha train impl

* Add adapter map for algo selection

* Add optional grad ckpt and algo selection

* Update __init__.py

* correct key name for loha

* Use custom fwd/bwd func and better init for loha

* Support gradient accumulation

* Fix bugs of loha

* use more stable init

* Add OFT training

* linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants