Closed
Conversation
Member
|
The A1111 implementation is wrong: https://github.com/KohakuBlueleaf/LyCORIS/blob/main/lycoris/modules/locon.py#L298 |
Author
|
Thanks for the link, I just opened up an issue here: KohakuBlueleaf/LyCORIS#196 I currently use alpha to adjust strength to the -1 / 1 range which makes my DoRAs more usable / more easily merged. My goal is to create DoRAs that work across all the different platforms as well as LoRAs do. |
KohakuBlueleaf
added a commit
to AUTOMATIC1111/stable-diffusion-webui
that referenced
this pull request
Jul 5, 2024
Merged
4 tasks
ruchej
pushed a commit
to ruchej/stable-diffusion-webui
that referenced
this pull request
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the DoRA implementation by moving the alpha application to after the weight_norm.
This aligns with A1111 allowing DoRA authors to target both platforms.
Example DoRA:
extremely_detailed_v2.zip
Base image (no DoRA)
Before patch (attached DoRA same seed)
(identity changed)
After patch
purrfect