Ensure samplers seed the global RNG even when add_noise is disabled#2841
Ensure samplers seed the global RNG even when add_noise is disabled#2841blepping wants to merge 1 commit intoComfy-Org:masterfrom blepping:fix_no_add_noise_seeding
Conversation
|
@comfyanonymous can you please take a look at this? having the seed ignored when there is only one possible case i can think of where this might affect existing generations, and that's something that interrupts sampling and then resumes it (with |
currently no global RNG seed gets set at all with the built in samplers (advanced KSampler, SamplerCustom) if
add_noiseis not enabled. this means anything using the global RNG (i.e.euler_a) will find the RNG in an undefined state. it becomes impossible to reproduce generations.this simple pull just ensures
torch.manual_seed()gets called even in the non-add_noisecode path.visual demonstration:
current behavior
with this pull
unfortunately, a lot of other custom nodes copy the current ComfyUI code with this issue and will need to be changed individually.
closes #2833 (i hope)