Skip to content

Fix missing include for poco 1.14.1#11196

Merged
timar merged 1 commit intoCollaboraOnline:masterfrom
dwt:update-to-poco-1.14.1
Feb 18, 2025
Merged

Fix missing include for poco 1.14.1#11196
timar merged 1 commit intoCollaboraOnline:masterfrom
dwt:update-to-poco-1.14.1

Conversation

@dwt
Copy link
Copy Markdown
Contributor

@dwt dwt commented Feb 18, 2025

Summary

This fixes compilation with poco 1.14.1 (and probably 1.14 - but I haven't explicitly tested that

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

@welcome
Copy link
Copy Markdown

welcome bot commented Feb 18, 2025

Thanks for opening this pull request!

Things that will help get your PR across the finish line:

@pedropintosilva
Copy link
Copy Markdown
Contributor

Thank you @dwt ! I have added @timar as a reviewer and approved GH workflow to run. Please sign off your commit by following the steps in https://github.com/CollaboraOnline/online/runs/37419454104 so it passes DCO check.

@dwt dwt force-pushed the update-to-poco-1.14.1 branch from b32f40f to 75f0dd4 Compare February 18, 2025 19:17
@dwt
Copy link
Copy Markdown
Contributor Author

dwt commented Feb 18, 2025

That's the first repo I've worked with that requires sign-off. Interesting. @pedropintosilva does that fix the sign-off thing?

Signed-off-by: Martin Häcker <mhaecker@mac.com>
Change-Id: I93eac16b7599c6650518c2fc6c3995f1afba4213
@timar timar force-pushed the update-to-poco-1.14.1 branch from 75f0dd4 to 9b01f13 Compare February 18, 2025 19:58
@timar
Copy link
Copy Markdown
Member

timar commented Feb 18, 2025

@timar timar merged commit abf7350 into CollaboraOnline:master Feb 18, 2025
@welcome
Copy link
Copy Markdown

welcome bot commented Feb 18, 2025

Thanks a lot for your contribution, and congrats on your first pull request merged! Welcome aboard! 🎉🎉🎉

If you haven't decided on your next task yet, take a look at our easy-hacks. We're looking forward to your next pull request! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[nix] build with poco 1.14.1 fails because of missing include

3 participants