Fix missing include for poco 1.14.1#11196
Merged
timar merged 1 commit intoCollaboraOnline:masterfrom Feb 18, 2025
Merged
Conversation
|
Thanks for opening this pull request! Things that will help get your PR across the finish line:
|
Contributor
|
Thank you @dwt ! I have added @timar as a reviewer and approved GH workflow to run. Please sign off your commit by following the steps in https://github.com/CollaboraOnline/online/runs/37419454104 so it passes DCO check. |
b32f40f to
75f0dd4
Compare
Contributor
Author
|
That's the first repo I've worked with that requires sign-off. Interesting. @pedropintosilva does that fix the sign-off thing? |
13 tasks
Signed-off-by: Martin Häcker <mhaecker@mac.com> Change-Id: I93eac16b7599c6650518c2fc6c3995f1afba4213
75f0dd4 to
9b01f13
Compare
Member
|
timar
approved these changes
Feb 18, 2025
|
Thanks a lot for your contribution, and congrats on your first pull request merged! Welcome aboard! 🎉🎉🎉 If you haven't decided on your next task yet, take a look at our easy-hacks. We're looking forward to your next pull request! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes compilation with poco 1.14.1 (and probably 1.14 - but I haven't explicitly tested that
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay