You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When compiling collabora-online with poco 1.14.1. (latest release) the build fails with errors like this:
In file included from kit/ChildSession.cpp:46:
./common/JsonUtil.hpp: In function'bool JsonUtil::parseJSON(const std::string&, Poco::JSON::Object::Ptr&)':./common/JsonUtil.hpp:45:47: error: expected unqualified-id before '&' token 45 | catch (const Poco::JSON::JSONException& exception) | ^./common/JsonUtil.hpp:45:47: error: expected ')' before '&' token 45 | catch (const Poco::JSON::JSONException& exception) | ~ ^ | )./common/JsonUtil.hpp:45:47: error: expected '{' before '&' token./common/JsonUtil.hpp:45:49: error: 'exception' was not declared in this scope; did you mean 'std::exception'? 45 | catch (const Poco::JSON::JSONException& exception) | ^~~~~~~~~ | std::exceptionIn file included from /nix/store/x5k7anh2zz9vbdicl0mbxyjd1kw4a8j4-gcc-14-20241116/include/c++/14-20241116/new:41, from /nix/store/x5k7anh2zz9vbdicl0mbxyjd1kw4a8j4-gcc-14-20241116/include/c++/14-20241116/bits/stl_construct.h:59, from /nix/store/x5k7anh2zz9vbdicl0mbxyjd1kw4a8j4-gcc-14-20241116/include/c++/14-20241116/bits/char_traits.h:57, from /nix/store/x5k7anh2zz9vbdicl0mbxyjd1kw4a8j4-gcc-14-20241116/include/c++/14-20241116/string:42, from /nix/store/7rgi6n33x0dd77yfxny284ij2kfgdhk0-poco-1.14.1-dev/include/Poco/Foundation.h:94, from /nix/store/7rgi6n33x0dd77yfxny284ij2kfgdhk0-poco-1.14.1-dev/include/Poco/Util/Util.h:23, from /nix/store/7rgi6n33x0dd77yfxny284ij2kfgdhk0-poco-1.14.1-dev/include/Poco/Util/XMLConfiguration.h:21, from kit/Kit.hpp:14, from kit/ChildSession.cpp:14:
I am not sure why this is needed, as there weren't any changes in the relevant header that seem like they are the source of this error. That said, it seems reasonable that there is an include missing, as the type is not actually imported. Still, my C++ is way too rusty to have a conclusive opinion on this.
So:
Can you explain why this patch was necessary?
Is there a better way to fix this build?
Would you consider adding this patch to the next version of collabora-online?
Describe the Bug
When compiling collabora-online with poco 1.14.1. (latest release) the build fails with errors like this:
Steps to Reproduce
2.nix-build --attr collabora-online --system aarch64-linux
Expected Behavior
It should build cleanly
Actual Behavior
It does not
Additional Context
I was able to work around it with this patch:
I am not sure why this is needed, as there weren't any changes in the relevant header that seem like they are the source of this error. That said, it seems reasonable that there is an include missing, as the type is not actually imported. Still, my C++ is way too rusty to have a conclusive opinion on this.
So: