-
Notifications
You must be signed in to change notification settings - Fork 0
Comparing changes
Open a pull request
base repository: Codeinwp/themeisle-sdk
base: d1ae68c
head repository: Codeinwp/themeisle-sdk
compare: a657eae
- 17 commits
- 15 files changed
- 11 contributors
Commits on May 14, 2026
-
Configuration menu - View commit details
-
Copy full SHA for eceb046 - Browse repository at this point
Copy the full SHA eceb046View commit details
Commits on May 26, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 902ff74 - Browse repository at this point
Copy the full SHA 902ff74View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f15c01 - Browse repository at this point
Copy the full SHA 0f15c01View commit details
Commits on Jun 9, 2026
-
Configuration menu - View commit details
-
Copy full SHA for b045e63 - Browse repository at this point
Copy the full SHA b045e63View commit details
Commits on Jun 14, 2026
-
Potential fix for pull request finding
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for bbf68ef - Browse repository at this point
Copy the full SHA bbf68efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d56ebb - Browse repository at this point
Copy the full SHA 4d56ebbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 196d4ca - Browse repository at this point
Copy the full SHA 196d4caView commit details
Commits on Jun 15, 2026
-
Configuration menu - View commit details
-
Copy full SHA for 709e19a - Browse repository at this point
Copy the full SHA 709e19aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c4032c - Browse repository at this point
Copy the full SHA 9c4032cView commit details
Commits on Jun 16, 2026
-
fix: repoint notice-dismiss callback to the method that exists
Promotions::load() registered the notice-dismiss AJAX handler against `ThemeisleSDK\Modules\Notification::regular_dismiss`, a method that does not exist anywhere in the SDK (the real handler is `Notification::dismiss`, which the SDK already references for this same action elsewhere). On a non-Neve site (`themeisle_sdk_promotions_neve_installed !== true`) the gated branch registers this callback. When it is reached as a user dismisses a review/promo notice, WordPress invokes it via WP_Hook (call_user_func_array) and PHP fatals: Uncaught TypeError: call_user_func_array(): Argument #1 ($callback) must be a valid callback, class ThemeisleSDK\Modules\Notification does not have a method "regular_dismiss" The result is an HTTP 500 / blank admin page on dismiss. Introduced in 644c183 (#175) and never had a matching method definition; affects every product bundling the SDK. Neve sites are spared only because the gate closes before the registration. Fix: point the callback at the existing `Notification::dismiss`. It is idempotent with the registration in `Notification::load()` (same static callback + priority de-dupes in WP_Hook), so behaviour is unchanged on sites that were never hitting the bug. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>Configuration menu - View commit details
-
Copy full SHA for 4022c8d - Browse repository at this point
Copy the full SHA 4022c8dView commit details -
Merge pull request #317 from Codeinwp/fix/notification-dismiss-callback
fix: repoint notice-dismiss callback to Notification::dismiss (regular_dismiss does not exist)
Configuration menu - View commit details
-
Copy full SHA for 9a85ada - Browse repository at this point
Copy the full SHA 9a85adaView commit details
Commits on Jun 17, 2026
-
Merge pull request #315 from Codeinwp/bugfix/1984
Fixed dashboard widget header
Configuration menu - View commit details
-
Copy full SHA for 835b5cd - Browse repository at this point
Copy the full SHA 835b5cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 586ec8c - Browse repository at this point
Copy the full SHA 586ec8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea6bfd6 - Browse repository at this point
Copy the full SHA ea6bfd6View commit details -
Merge pull request #316 from Codeinwp/feat/about-us-services-section
Feat/about us services section
Configuration menu - View commit details
-
Copy full SHA for b30a457 - Browse repository at this point
Copy the full SHA b30a457View commit details
Commits on Jun 18, 2026
-
- Fixes dashboard widget header placement on latest WordPress core version; - Adds about us services section; - Fixes notice dismiss using wrong function name as callback;
Configuration menu - View commit details
-
Copy full SHA for 71a0be9 - Browse repository at this point
Copy the full SHA 71a0be9View commit details -
chore(release): 3.3.53 [skip ci]
##### [Version 3.3.53](Codeinwp/themeisle-sdk-main@v3.3.52...v3.3.53) (2026-06-18) - Fixes dashboard widget header placement on latest WordPress core version; - Adds about us services section; - Fixes notice dismiss using wrong function name as callback;
Configuration menu - View commit details
-
Copy full SHA for a657eae - Browse repository at this point
Copy the full SHA a657eaeView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff d1ae68c...a657eae