Skip to content

Finding in workspace #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukepistrol merged 8 commits into from
Mar 22, 2022
Merged

Finding in workspace #125

lukepistrol merged 8 commits into from
Mar 22, 2022

Conversation

@RayZhao1998
Copy link
Collaborator

@RayZhao1998 RayZhao1998 commented Mar 20, 2022 •
edited
Loading

This PR is to implement finding in workspace, only matched case.

Current state:

截屏2022-03-23 上午1 32 49

  • Basic views
  • Highlight keywords
  • Search all files
  • Click to jump to corresponding file

@lukepistrol lukepistrol added enhancement New feature or request UI This is UI related labels Mar 20, 2022
@RayZhao1998 RayZhao1998 force-pushed the feature/workspace-search branch 2 times, most recently from 2abc1c2 to 539c3b0 Compare March 22, 2022 15:26
@RayZhao1998 RayZhao1998 force-pushed the feature/workspace-search branch from 539c3b0 to 2bbcdcb Compare March 22, 2022 16:35
@RayZhao1998 RayZhao1998 force-pushed the feature/workspace-search branch from 2bbcdcb to d994e76 Compare March 22, 2022 16:38
@RayZhao1998 RayZhao1998 marked this pull request as ready for review March 22, 2022 17:33
@RayZhao1998 RayZhao1998 requested review from austincondiff, lukepistrol and pkasila and removed request for pkasila March 22, 2022 17:33
austincondiff
austincondiff approved these changes Mar 22, 2022
View reviewed changes
Copy link
Collaborator

@austincondiff austincondiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Outstanding work!

@RayZhao1998
Copy link
Collaborator Author

RayZhao1998 commented Mar 22, 2022 •
edited
Loading

Finding in workspace is a huge functionality. There's still a lot of work to do. I'll file an issue to list remaining work to do tomorrow.

@lukepistrol lukepistrol merged commit fffef88 into CodeEditApp:main Mar 22, 2022
@RayZhao1998 RayZhao1998 mentioned this pull request Mar 23, 2022
Closed
6 tasks
xinix909 pushed a commit to xinix909/CodeTransfer that referenced this pull request Sep 7, 2024
@lukepistrol
[chore]: Update CodeEditLanguages to 0.1.9 (CodeEditApp#125)
7a0a415
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@austincondiff austincondiff austincondiff approved these changes

@lukepistrol lukepistrol lukepistrol approved these changes

Assignees

@RayZhao1998 RayZhao1998

Labels

enhancement New feature or request UI This is UI related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RayZhao1998 @austincondiff @lukepistrol