fix(pinia-orm): @OnDelete on same model attrs leads to undefined error#754
Merged
CodeDredd merged 2 commits intonext-releasefrom Dec 21, 2022
Merged
fix(pinia-orm): @OnDelete on same model attrs leads to undefined error#754CodeDredd merged 2 commits intonext-releasefrom
CodeDredd merged 2 commits intonext-releasefrom
Conversation
Merged
CodeDredd
added a commit
that referenced
this pull request
Dec 22, 2022
* perf(pinia-orm): Improve hydrating check (#679) * perf(pinia-orm): Improve hydrating check * perf(pinia-orm): add checking for composite keys * refactor(pinia-orm): remove not needed update prop * refactor(pinia-orm): small improvement * feat(pinia-orm): add `hasManyThrough` relation (#678) * feat(pinia-orm): add `hasManyThrough` relation * test(pinia-orm): add make test * test(pinia-orm): remove console log * docs(pinia-orm): small typo * docs(pinia-orm): update readme * docs(pinia-orm): update readme * fix(pinia-orm): updates where ignored in hydration * refactor(pinia-orm): typo has many through * refactor(pinia-orm): improve relation code * fix(pinia-orm): update hook not triggered with `update` method * refactor(pinia-orm): Improve hydrating saving * refactor(pinia-orm): Improve typescript handling with `piniaStore()` * fix(pinia-orm): @onDelete on same model attrs leads to undefined error (#754) * fix(pinia-orm): @onDelete and Attr(object) leads to undefined error closes #748 * refactor(pinia-orm): linting * refactor(pinia-orm): remove console.log * feat(pinia-orm): Add the possibility to rollback changed models. closes #756 * docs(pinia-orm): Add documentation * perf(pinia-orm): Remove `JSON.stringfy` for comparing objects * docs(pinia-orm): Add some missing model functions to api * fix(pinia-orm): Don't delete relations bind with `onDelete` if hook returns false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
closes #748
❓ Type of change
📚 Description
If you have the name attributes with diffrent behaviour and using
onDeleteit causes an error because the attribute names are registered on model level instead for the entity itself.📝 Checklist