Skip to content

feat(pinia-orm): Add the option to sort case insensitive with sortBy#636

Merged
CodeDredd merged 1 commit intonext-releasefrom
sortby-enhance
Nov 28, 2022
Merged

feat(pinia-orm): Add the option to sort case insensitive with sortBy#636
CodeDredd merged 1 commit intonext-releasefrom
sortby-enhance

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Nov 28, 2022 •
edited
Loading

🔗 Linked issue

#634

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Adding the option to sort collections case insensitive:

const userCollection = useCollect(useRepo(User).make([
    { id: 1, name: 'James', age: 40, post: { id: 1, title: 'Title1' } },
    { id: 2, name: 'john', age: 30, post: { id: 2, title: 'Title2' } },
    { id: 3, name: 'David', age: 20 },
  ])).sortBy('name', 'SORT_FLAG_CASE')

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the enhancement New feature or request label Nov 28, 2022
@CodeDredd CodeDredd self-assigned this Nov 28, 2022
@CodeDredd CodeDredd changed the base branch from master to next-release November 28, 2022 12:28
@CodeDredd CodeDredd merged commit eb6e3c4 into next-release Nov 28, 2022
@CodeDredd CodeDredd deleted the sortby-enhance branch November 28, 2022 12:28
@CodeDredd CodeDredd mentioned this pull request Nov 28, 2022
Merged
CodeDredd added a commit that referenced this pull request Dec 6, 2022
@CodeDredd
v1.3.0 (#637)
ccb8472 
* fix(pinia-orm): Query constraints with nested relations in m:m relations broken (#625)

* fix(pinia-orm): Query constraints with nested relations in m:m relations broken

* refactor(pinia-orm): remove skip in test

* feat(pinia-orm): Add the option to sort case insensitive with `sortBy` (#636)

* docs(pinia-orm): Add requirements info for nuxt 2 users (#638)

* refactor(normalizr): reduce code to only used by orm (#641)

* perf(pinia-orm-659): Save hydrated models if not updated (#671)

* perf(pinia-orm-659): Save hydrated models if not updated

* refactor(pinia-orm): typo

closes #659, #623, #628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@CodeDredd CodeDredd

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CodeDredd