Skip to content

perf(pinia-orm): Improve hydrating check#679

Merged
CodeDredd merged 4 commits intonext-releasefrom
improve-659
Dec 7, 2022
Merged

perf(pinia-orm): Improve hydrating check#679
CodeDredd merged 4 commits intonext-releasefrom
improve-659

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Dec 7, 2022

🔗 Linked issue

related #659

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Improve hydration check

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the enhancement New feature or request label Dec 7, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 7, 2022

Codecov Report

Base: 0.00% // Head: 99.73% // Increases project coverage by +99.73% 🎉

Coverage data is based on head (597c2ea) compared to base (b3f22c1).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           next-release     #679       +/-   ##
=================================================
+ Coverage              0   99.73%   +99.73%     
=================================================
  Files                 0       83       +83     
  Lines                 0     5322     +5322     
  Branches              0      487      +487     
=================================================
+ Hits                  0     5308     +5308     
- Misses                0       14       +14     
Impacted Files Coverage Δ
packages/pinia-orm/src/query/Query.ts 99.89% <100.00%> (ø)
...model/decorators/attributes/relations/HasManyBy.ts 100.00% <0.00%> (ø)
...es/pinia-orm/src/packages/uuid/decorators/UidV1.ts 100.00% <0.00%> (ø)
...rm/src/model/attributes/relations/BelongsToMany.ts 100.00% <0.00%> (ø)
packages/pinia-orm/src/model/Model.ts 100.00% <0.00%> (ø)
...ckages/pinia-orm/src/model/attributes/Attribute.ts 100.00% <0.00%> (ø)
packages/pinia-orm/src/model/casts/BooleanCast.ts 100.00% <0.00%> (ø)
...ckages/pinia-orm/src/packages/uuid/casts/V1Cast.ts 100.00% <0.00%> (ø)
...ia-orm/src/model/attributes/relations/BelongsTo.ts 100.00% <0.00%> (ø)
...-orm/src/model/decorators/attributes/types/Attr.ts 100.00% <0.00%> (ø)
... and 74 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CodeDredd CodeDredd merged commit 222b52e into next-release Dec 7, 2022
@CodeDredd CodeDredd deleted the improve-659 branch December 7, 2022 08:25
@CodeDredd CodeDredd mentioned this pull request Dec 7, 2022
CodeDredd added a commit that referenced this pull request Dec 22, 2022
* perf(pinia-orm): Improve hydrating check (#679)

* perf(pinia-orm): Improve hydrating check

* perf(pinia-orm): add checking for composite keys

* refactor(pinia-orm): remove not needed update prop

* refactor(pinia-orm): small improvement

* feat(pinia-orm): add `hasManyThrough` relation (#678)

* feat(pinia-orm): add `hasManyThrough` relation

* test(pinia-orm): add make test

* test(pinia-orm): remove console log

* docs(pinia-orm): small typo

* docs(pinia-orm): update readme

* docs(pinia-orm): update readme

* fix(pinia-orm): updates where ignored in hydration

* refactor(pinia-orm): typo has many through

* refactor(pinia-orm): improve relation code

* fix(pinia-orm): update hook not triggered with `update` method

* refactor(pinia-orm): Improve hydrating saving

* refactor(pinia-orm): Improve typescript handling with `piniaStore()`

* fix(pinia-orm): @onDelete on same model attrs leads to undefined error (#754)

* fix(pinia-orm): @onDelete and Attr(object) leads to undefined error
closes #748

* refactor(pinia-orm): linting

* refactor(pinia-orm): remove console.log

* feat(pinia-orm): Add the possibility to rollback changed models.
closes #756

* docs(pinia-orm): Add documentation

* perf(pinia-orm): Remove `JSON.stringfy` for comparing objects

* docs(pinia-orm): Add some missing model functions to api

* fix(pinia-orm): Don't delete relations bind with `onDelete` if hook returns false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants