Skip to content

fix(pinia-orm): Query constraints with nested relations in m:m relations broken#625

Merged
CodeDredd merged 2 commits intonext-releasefrom
pinia-orm-623
Nov 28, 2022
Merged

fix(pinia-orm): Query constraints with nested relations in m:m relations broken#625
CodeDredd merged 2 commits intonext-releasefrom
pinia-orm-623

Conversation

@CodeDredd
Copy link
Copy Markdown
Owner

@CodeDredd CodeDredd commented Nov 25, 2022

🔗 Linked issue

closes #623

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@CodeDredd CodeDredd added the bug Something isn't working label Nov 25, 2022
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 25, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (next-release@b63bd31). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             next-release     #625   +/-   ##
===============================================
  Coverage                ?   99.73%           
===============================================
  Files                   ?       83           
  Lines                   ?     5289           
  Branches                ?      481           
===============================================
  Hits                    ?     5275           
  Misses                  ?       14           
  Partials                ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeDredd CodeDredd changed the base branch from master to next-release November 28, 2022 12:26
@CodeDredd CodeDredd merged commit baf0304 into next-release Nov 28, 2022
@CodeDredd CodeDredd deleted the pinia-orm-623 branch November 28, 2022 12:27
@CodeDredd CodeDredd mentioned this pull request Nov 28, 2022
CodeDredd added a commit that referenced this pull request Dec 6, 2022
* fix(pinia-orm): Query constraints with nested relations in m:m relations broken (#625)

* fix(pinia-orm): Query constraints with nested relations in m:m relations broken

* refactor(pinia-orm): remove skip in test

* feat(pinia-orm): Add the option to sort case insensitive with `sortBy` (#636)

* docs(pinia-orm): Add requirements info for nuxt 2 users (#638)

* refactor(normalizr): reduce code to only used by orm (#641)

* perf(pinia-orm-659): Save hydrated models if not updated (#671)

* perf(pinia-orm-659): Save hydrated models if not updated

* refactor(pinia-orm): typo

closes #659, #623, #628
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subrelations broken after many to many

2 participants