Skip to content

Added module_name attribute.#209

Merged
mrackwitz merged 7 commits into
masterfrom
module-name-attribute
Dec 7, 2014
Merged

Added module_name attribute.#209
mrackwitz merged 7 commits into
masterfrom
module-name-attribute

Conversation

@neonichu

@neonichu neonichu commented Dec 6, 2014

Copy link
Copy Markdown
Member

Closes #205

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should just be [#205]

Comment thread spec/specification_spec.rb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about normalising instead?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea!

Comment thread spec/specification_spec.rb Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should characters with accents instead be mapped to those without accents? Eloy's name is not built up of invalid characters.

á should be shown as a instead of _?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, was changed in f65331b

mrackwitz added a commit that referenced this pull request Dec 7, 2014
@mrackwitz mrackwitz merged commit 7caf929 into master Dec 7, 2014
@mrackwitz mrackwitz deleted the module-name-attribute branch December 7, 2014 17:49
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
@coveralls

Copy link
Copy Markdown

Coverage Status

Changes Unknown when pulling ed492e9 on module-name-attribute into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frameworks] Allow to customize the module name

7 participants