Skip to content

Added use_frameworks! flag to DSL.#208

Merged
neonichu merged 2 commits into
masterfrom
use-frameworks-flag
Dec 5, 2014
Merged

Added use_frameworks! flag to DSL.#208
neonichu merged 2 commits into
masterfrom
use-frameworks-flag

Conversation

@neonichu

@neonichu neonichu commented Dec 4, 2014

Copy link
Copy Markdown
Member

Closes #204

Comment thread CHANGELOG.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double backticks for use_frameworks!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double space after the .

@neonichu neonichu force-pushed the use-frameworks-flag branch from 7659dd9 to 2dd5ef3 Compare December 5, 2014 00:45

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on 7659dd9 (possibly garbage-collected): I would keep the default parameter also on the target definition level, so that use_frameworks! can be used in the same way as on the root level.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default parameter was restored :)

neonichu added a commit that referenced this pull request Dec 5, 2014
Added use_frameworks! flag to DSL.
@neonichu neonichu merged commit 7f55b95 into master Dec 5, 2014
@neonichu neonichu deleted the use-frameworks-flag branch December 5, 2014 22:51
Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Frameworks] Allow to opt-in using Podfile DSL to integrate pods as frameworks

4 participants