Skip to content

Framework / Swift Support in CocoaPods#195

Merged
kylef merged 1 commit into
masterfrom
swift
Nov 20, 2014
Merged

Framework / Swift Support in CocoaPods#195
kylef merged 1 commit into
masterfrom
swift

Conversation

@mrackwitz

Copy link
Copy Markdown
Member

This seems to be all what is needed at the Core to support Frameworks & Swift, currently.

@segiddins

Copy link
Copy Markdown
Member

👍

@kylef

kylef commented Nov 9, 2014

Copy link
Copy Markdown
Contributor

👍 Can't wait to merge all this stuff.

@kylef

kylef commented Nov 20, 2014

Copy link
Copy Markdown
Contributor

:shipit:

kylef added a commit that referenced this pull request Nov 20, 2014
Framework / Swift Support in CocoaPods
@kylef kylef merged commit 653c497 into master Nov 20, 2014
@kylef kylef deleted the swift branch November 20, 2014 19:45
@mrackwitz mrackwitz restored the swift branch November 22, 2014 17:33

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this will work fine in practice, it’s better to not ever provide such values as floats, but as a string instead. Can you update this please?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. 👍

@alloy

alloy commented Nov 24, 2014

Copy link
Copy Markdown
Member

@mrackwitz Another epic PR in this series 😜

Ashton-W pushed a commit to Ashton-W/Core that referenced this pull request Nov 2, 2015
Framework / Swift Support in CocoaPods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants