Adds support for passing in related podspecs for validation by orta · Pull Request #8536 · CocoaPods/CocoaPods

orta · 2019-02-21T14:05:28Z

The React Native team are starting to do more work with CocoaPods facebook/react-native#23559 , and I'd like to get them using pod lib lint on CI. To do that though, they would need the ability to say "Lint this Podspec, but grab all these other ones from the local repo" - and they have some dependencies which we're currently grabbing from trunk.

This adds support in the validator to declare local (or remote) podspecs as a part of your linting setup across pod lib lint, pod spec lint and the validation aspect of pod repo push.

orta · 2019-02-21T14:49:18Z

    #-------------------------------------------------------------------------#

-    #  @!group Configuration
+    #  @!group Configuration


This was an unknown invisible char - I switched it to a space

dnkoutso · 2019-02-21T16:44:38Z

Why would spec lint and repo push accept these parameters? Wouldn't we want to limit this to lib lint only (local?)

orta · 2019-02-21T17:18:37Z

You wouldn't be able to push to a non-trunk specs repo you owned without this. You can't ship x Podspecs at once, and there's no way to skip validation. So this allows pod repo push to work.

At that point not having it in lib lint just seemed like an odd edge case.

paulb777 · 2019-02-21T17:29:15Z

But shouldn't spec lint and repo push require dependencies to be pushed to a spec repo? Otherwise won't it be possible to create an inconsistent spec repo?

dnkoutso · 2019-02-21T17:36:56Z

You wouldn't be able to push to a non-trunk specs repo you owned without this.

How is the information passed through these parameters reconciled with the dependency list declared in the podspec?

In other words, if I pass this parameter and I successfully publish a podspec but I don't have s.dependency declared will this published podspec be consumable and work?

It seems to me a way to handle this is to write out support for a LocalSource that can be added and maintained by the repo list or we explicitly enable this option for lib lint only.

orta · 2019-02-21T21:29:35Z

Hrm, yeah, just had a 2nd thought about that - will remove it from repo push and spec lint

segiddins · 2019-02-22T08:55:52Z

  [dacaiguoguogmail](https://github.com/dacaiguoguogmail)
  [#8470](https://github.com/CocoaPods/CocoaPods/pull/8470)

+* Adds support for referring to other podspecs during validation 


needs two trailing spaces instead of 1

segiddins · 2019-02-22T08:57:05Z

      local    = local?
      urls     = source_urls
+
+      additional_podspec_pods = Dir.glob(external_podspecs || '')


Should this be external_podspecs ? Dir.glob(external_podspecs) : []?

I originally did this, but it felt a bit weird re-defining the same variable to be a different type. I'm happy to change this if it's a blocker though 👍

doh - forgot to push this, hah

dont care so much about the variable name, but I dont like having a call to Dir.glob('')

Ah, that makes sense - will fix

segiddins · 2019-02-22T08:57:53Z

+
+        podfile = @validator.send(:podfile_from_spec, :ios, '5.0')
+
+        puts podfile.target_definitions['App'].dependencies


debugging code

Nice catch, thanks - fixed

segiddins · 2019-02-22T08:58:01Z

+
+        podfile = @validator.send(:podfile_from_spec, :ios, '5.0')
+
+        puts podfile.target_definitions['App'].dependencies


debugging code

dnkoutso · 2019-02-24T18:22:23Z

  [#8461](https://github.com/CocoaPods/CocoaPods/issues/8461)

-* Set the path of development pod groups to root directory of the Pod 
+* Adds support for referring to other podspecs during validation  


nit: needs to move to updated master section after 1.7.0.beta.1

👍 cool, yeah, done

@orta is this an enhancement or bug fix?

Moved it to enhancement

… podspecs without going through a podspec source

… lib lint, spec lint and repo push

dnkoutso · 2019-03-02T03:42:49Z

  [#8461](https://github.com/CocoaPods/CocoaPods/issues/8461)

-* Set the path of development pod groups to root directory of the Pod 
+* Set the path of development pod groups to root directory of the Pod  


change intended?

Yep, it fixes that line (should also be two spaces)

dnkoutso · 2019-03-07T18:58:11Z

+
+          additional_path_pods.each do |podspec_path|
+            podspec_name = File.basename(podspec_path, '.*')
+            pod podspec_name, :path => File.dirname(podspec_path), :inhibit_warnings => false


why would we not inhibit warnings? Those are external pods not currently being validated. I would expect to remove :inhibit_warnings here and below.

amorde · 2019-03-08T17:43:00Z

+        coconut_dep = podfile.target_definitions['App'].dependencies[1]
+        coconut_dep.name.should == 'CoconutLib'
+        coconut_dep.local?.should.nil?
+        coconut_dep.external?.should.not.nil?


should.be.true?

amorde · 2019-03-08T17:43:16Z

+
+        coconut_dep = podfile.target_definitions['App'].dependencies[1]
+        coconut_dep.name.should == 'CoconutLib'
+        coconut_dep.local?.should.not.nil?


should.be.true?

Nope, they're strings, this is fine 👍

Source [PR 8536](CocoaPods/CocoaPods#8536)

…ommand (#14579) * Add new cocoapods 1.7 parameters of the lint command Source [PR 8536](CocoaPods/CocoaPods#8536) * Add cocoapods version hint

…ommand (fastlane#14579) * Add new cocoapods 1.7 parameters of the lint command Source [PR 8536](CocoaPods/CocoaPods#8536) * Add cocoapods version hint

orta force-pushed the ort-multi-podspec-linter-rn branch 3 times, most recently from d467155 to af65a75 Compare February 21, 2019 14:42

orta commented Feb 21, 2019

View reviewed changes

dnkoutso added this to the 1.7.0 milestone Feb 21, 2019

segiddins reviewed Feb 22, 2019

View reviewed changes

orta force-pushed the ort-multi-podspec-linter-rn branch from af65a75 to c42a26b Compare February 22, 2019 12:48

dnkoutso reviewed Feb 24, 2019

View reviewed changes

orta added 6 commits February 25, 2019 14:33

Initial stab at adding options to the validator to include additional…

d855212

… podspecs without going through a podspec source

Adds specs for the validator and adds the ability to use the falgs in…

3c95720

… lib lint, spec lint and repo push

Adds a CHANGELOG entry

42d607a

Appease the rubocop

0acd3b0

Remove the local podspec refs in spec lint, and repo push

0cee62a

Removes debugging code from the test

277faa6

orta force-pushed the ort-multi-podspec-linter-rn branch 2 times, most recently from 6317f87 to ad22d08 Compare February 27, 2019 23:40

dnkoutso reviewed Mar 2, 2019

View reviewed changes

dnkoutso approved these changes Mar 2, 2019

View reviewed changes

dnkoutso reviewed Mar 7, 2019

View reviewed changes

dnkoutso approved these changes Mar 7, 2019

View reviewed changes

orta force-pushed the ort-multi-podspec-linter-rn branch from ad22d08 to 6f03a82 Compare March 7, 2019 19:05

amorde approved these changes Mar 8, 2019

View reviewed changes

orta force-pushed the ort-multi-podspec-linter-rn branch 2 times, most recently from 4234a28 to 67d5997 Compare March 10, 2019 22:10

Updates the CHANGELOG entry post 1.7.0b1

fa0379b

orta force-pushed the ort-multi-podspec-linter-rn branch from 67d5997 to fa0379b Compare March 11, 2019 02:06

dnkoutso merged commit 39b9f74 into master Mar 26, 2019

dnkoutso deleted the ort-multi-podspec-linter-rn branch March 26, 2019 17:24

mfiebig added a commit to mfiebig/fastlane that referenced this pull request Apr 12, 2019

Add new cocoapods 1.7 parameters of the lint command

e24864d

Source [PR 8536](CocoaPods/CocoaPods#8536)

mfiebig mentioned this pull request Apr 12, 2019

[action] pod_lib_lint: Add new cocoapods 1.7 parameters of the lint command fastlane/fastlane#14579

Merged

4 tasks

jtreanor mentioned this pull request Oct 8, 2019

CircleCI: Use --include-podspecs when validating WordPress-Editor-iOS podspec to avoid publishing problems wordpress-mobile/AztecEditor-iOS#1220

Merged


		podfile = @validator.send(:podfile_from_spec, :ios, '5.0')

		puts podfile.target_definitions['App'].dependencies

Conversation

orta commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dnkoutso commented Feb 21, 2019

Uh oh!

orta commented Feb 21, 2019

Uh oh!

paulb777 commented Feb 21, 2019

Uh oh!

dnkoutso commented Feb 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

orta commented Feb 21, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

orta commented Feb 21, 2019 •

edited

Loading

dnkoutso commented Feb 21, 2019 •

edited

Loading