Skip to content

[Project] Legacy Build Location Support#3183

Merged
alloy merged 3 commits into
masterfrom
samdmarshall-xclegacy-build-setting-build-dir-fix
Feb 24, 2015
Merged

[Project] Legacy Build Location Support#3183
alloy merged 3 commits into
masterfrom
samdmarshall-xclegacy-build-setting-build-dir-fix

Conversation

@alloy

@alloy alloy commented Feb 24, 2015

Copy link
Copy Markdown
Member

Replaces #2880.

@samdmarshall What do you think?

Comment thread lib/cocoapods/project.rb Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no space here

@segiddins

Copy link
Copy Markdown
Member

Seems fine, but it requires a rebase, and I'm not sure travis ran.

@alloy alloy force-pushed the samdmarshall-xclegacy-build-setting-build-dir-fix branch from ca12bf3 to dcfc2e3 Compare February 24, 2015 19:46
@alloy

alloy commented Feb 24, 2015

Copy link
Copy Markdown
Member Author

@segiddins Removed space and rebased, thanks for looking 👍

alloy added a commit that referenced this pull request Feb 24, 2015
…etting-build-dir-fix

[Project] Legacy Build Location Support
@alloy alloy merged commit d403508 into master Feb 24, 2015
@alloy alloy deleted the samdmarshall-xclegacy-build-setting-build-dir-fix branch February 24, 2015 19:47
@neonichu

Copy link
Copy Markdown
Member

@samdmarshall 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants