Merged
Conversation
4618e4b to
daaa0d0
Compare
jfriesse
approved these changes
Feb 8, 2021
Member
jfriesse
left a comment
There was a problem hiding this comment.
Looks great and makes libqb a bit more multi thread friendly so ACK. I would just consider increasing sleep timeout in test to prevent false failures because of clogged CI.
Fix several locking issues reported by helgrind
daaa0d0 to
4faad21
Compare
Contributor
Author
|
Thanks for the review. merged. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Oct 11, 2021
https://build.opensuse.org/request/show/924180 by user yan_gao + dimstar_suse - Update to version 2.0.3+20210303.404adbc (v2.0.3): - syslog: Add a message-id parameter for messages (gh#ClusterLabs/libqb#433) - timers: Add some locking (gh#ClusterLabs/libqb#436) - ipcc: Have a few goes at tidying up after a dead server (gh#ClusterLabs/libqb#434) - strlcpy: Check for maxlen underflow (gh#ClusterLabs/libqb#432) - doxygen2man: fix printing of lines starting with '.' (gh#ClusterLabs/libqb#431) - doxygen2man: ignore all-whitespace brief descriptions (gh#ClusterLabs/libqb#430) (forwarded request 924179 from yan_gao)
|
While this patch is technically correct, unless the title was “all” it should be reverted. This sets a precedent this library supports concurrency. It doesn’t, and this small change doesn’t move things any closer, if concurrency supports is a goal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix several locking issues reported by helgrind