Expand upstream SQL test allowlist (+342 tests, batches 1–6)#712
Merged
Conversation
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/111da3b1-60b1-4463-a2f6-81f273b71557 Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/111da3b1-60b1-4463-a2f6-81f273b71557 Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
|
|
Copilot created this pull request from a session on behalf of
peter-leonov-ch
May 9, 2026 11:18
View session
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/ff6b0ebd-bf39-4b26-9bb2-1325f729e40a Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
…TS.md Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/90381f5c-1448-4476-bb88-5f6c78b94c8c Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Expands the upstream ClickHouse stateless SQL test allowlist used by tests/clickhouse-test-runner, increasing the set of upstream tests exercised in CI across both harness backends (client, http) and both server versions (latest, head). Also documents the harness’s purpose and the batch-based allowlist growth strategy (including the prefix/substring match pitfall) for future maintenance.
Changes:
- Add ~388 new upstream stateless SQL test names to
upstream-allowlist.txt(net allowlist now 424 entries). - Extend
AGENTS.mdwith a clear explanation of the harness behavior and a repeatable, batch-driven method for growing/pruning the allowlist.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/clickhouse-test-runner/upstream-allowlist.txt | Expands the curated list of upstream stateless SQL tests to run through the Node.js harness in CI. |
| AGENTS.md | Documents the harness behavior and a process for safely growing the allowlist (including prefix-match gotchas). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
peter-leonov-ch
approved these changes
May 9, 2026
peter-leonov-ch
added a commit
that referenced
this pull request
May 9, 2026
`AGENTS.md` had drifted from reality after PRs #662–#712: it claimed `examples/web` has no `performance/` folder, pointed at a placeholder docs path, and said nothing about the `skills/` directory or the `.claude/skills/setup/` skill that replaced `copilot-setup-steps.yml`. ## Summary - **Examples › `performance/`** — drop the "no `performance/` folder under `examples/web`" claim; #701 added one for browser-safe streaming. - **Log-message docs guidance** — point at the real `docs/` layout from #677 (`docs/socket_hang_up_econnreset.md`, `docs/howto/`) instead of a fictional `docs/example-log-message.md`. The example URL in the snippet now also resolves to a real page (`docs/socket_hang_up_econnreset.md`). - **New `Skills` section** — documents the repo-root `skills/` directory (#681, #682, #702): `client-node`'s `prepack` ships it via `@clickhouse/client`, the `agents.skills` field of `packages/client-node/package.json` declares which skills are discoverable, and the `Skills E2E` workflow (`.github/workflows/e2e-skills.yml`, backed by `tests/e2e/skills/check.js`) asserts the packaged tarball contains the declared skills. Routes contributors to `.claude/skills/setup/SKILL.md` (#705) instead of re-introducing `copilot-setup-steps.yml`. - **`agents.skills` manifest** — adds `clickhouse-js-node-coding` alongside `clickhouse-js-node-troubleshooting` so both shipped skills are discoverable to downstream tooling. `tests/e2e/skills/check.js` is extended to verify both skills land in the packaged `@clickhouse/client` tarball. - **New `Embedded docs` section** — surfaces `docs/` as the preferred home for pages linked from log messages. - **CHANGELOG guidance** — aligns with the PR template: entry goes in the PR description and is folded into `CHANGELOG.md` at release time. Documentation refresh plus a small manifest/test change to make the second shipped skill discoverable. ## Checklist - [x] A human-readable description of the changes was provided to include in CHANGELOG --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com> Co-authored-by: Peter Leonov <peter.leonov@clickhouse.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #708 / #710 by growing
tests/clickhouse-test-runner/upstream-allowlist.txtfrom 36 → 424 entries through the Node.js harness, validated on bothclientandhttpbackends.clientandhttpbackends--no-stateful --no-long, keep passers, drop failures and skips)clientandhttpbackends and were kept; 257 failures and 1 skip dropped); allowlist 36 → 378{client,http} × {head,latest}) or that act as prefix matches for failing tests (clickhouse-test treats positional args as substring/prefix matches, so e.g.00396_uuidwas unintentionally pulling in the failing00396_uuid_v7). Net: allowlist now 424 entries (+388 vs the pre-Expand upstream SQL test allowlist #710 baseline of 36)AGENTS.mdso future agent runs have the context