Run upstream ClickHouse SQL test suite against @clickhouse/client#707
Closed
Copilot wants to merge 3 commits into
Closed
Run upstream ClickHouse SQL test suite against @clickhouse/client#707Copilot wants to merge 3 commits into
Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/082ff17d-204a-4d87-8da8-e9a080a4a54b Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/082ff17d-204a-4d87-8da8-e9a080a4a54b Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ClickHouse/clickhouse-js/sessions/082ff17d-204a-4d87-8da8-e9a080a4a54b Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
peter-leonov-ch
May 8, 2026 18:30
View session
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
6 tasks
Collaborator
peter-leonov-ch
added a commit
that referenced
this pull request
May 9, 2026
…#708) Fix CI errors from #707. - [x] Remove `--print-time` from workflow + README example (it isn't a valid `tests/clickhouse-test` flag) - [x] Remove unused `clickhouse_version` `workflow_dispatch` input from `upstream-sql-tests.yml` - [x] Remove unused `UPSTREAM_REF` env var from `upstream-sql-tests.yml` - [x] Install `jinja2` in `upstream-sql-tests.yml` - [x] Fix `MaxListenersExceededWarning` in `client` backend by replacing `pipeline(result.stream, process.stdout, { end: false })` with `for await (const chunk of result.stream)` so no error/close listeners accumulate on stdout - [x] Keep `--trace-warnings` enabled in `tests/clickhouse-test-runner/bin/clickhouse` so any future Node warnings include their stack traces in CI logs --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com> Co-authored-by: Peter Leonov <peter.leonov@clickhouse.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #706. The wrapper CLI was merged but orchestration was still manual ("download the test files, splice
bin/intoPATH, run by hand"). This PR makes that flow reproducible locally and exercised in CI, without forcing a multi-GB clone ofClickHouse/ClickHouse.tests/clickhouse-test-runner/scripts/run-upstream-tests.sh— driver that builds the wrapper if needed, readsupstream-allowlist.txt, exportsPATH/log path/impl, thenexecspython3 tests/clickhouse-test "${tests[@]}" "$@"from the upstream checkout. Knobs:UPSTREAM_CLICKHOUSE_DIR,UPSTREAM_TEST_LIST,CLICKHOUSE_CLIENT_CLI_IMPL,CLICKHOUSE_CLIENT_CLI_LOG. Extra args are forwarded.tests/clickhouse-test-runner/upstream-allowlist.txt— curated test list, seeded with01428_hash_set_nan_key. One name per line,#for comments, whitespace trimmed..github/workflows/upstream-sql-tests.yml— standalone workflow (not in thesuccessaggregator). Uses a secondactions/checkoutwithrepository: ClickHouse/ClickHouse,fetch-depth: 1, andsparse-checkout:limited totests/clickhouse-test,tests/queries,tests/config,tests/ci,tests/performance,docker/test/util— no full clone. Matriximpl: [client, http]×clickhouse: [head, latest]. Triggers:workflow_dispatch(withupstream_ref/clickhouse_versioninputs), nightly cron, and push/PR scoped totests/clickhouse-test-runner/**. Run log +*.stdout/*.stderr/*.diffalways uploaded as artifacts.CONTRIBUTING.mdandAGENTS.mdget pointer entries..gitignoreexcludes.upstream/.Local usage:
The allowlist is intentionally tiny on day one — it grows as we triage which upstream tests pass cleanly through
clientandhttpbackends. The nightly run againstmasteris what surfaces upstream drift (newtests/clickhouse-testflags,extract-from-configkeys, or settings classification changes that the wrapper needs to keep up with).Checklist