Skip to content

Fix OTEL SDK teardown errors breaking CI with vitest 4.1.0#620

Merged
peter-leonov-ch merged 2 commits intodependabot/npm_and_yarn/dev-dependencies-19b399dc78from
copilot/sub-pr-610
Mar 16, 2026
Merged

Fix OTEL SDK teardown errors breaking CI with vitest 4.1.0#620
peter-leonov-ch merged 2 commits intodependabot/npm_and_yarn/dev-dependencies-19b399dc78from
copilot/sub-pr-610

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 15, 2026

Summary

vitest 4.1.0 (bumped by dependabot) now awaits and propagates OTEL SDK shutdown() errors as fatal. When OTEL_EXPORTER_OTLP_ENDPOINT is unavailable, the SDK falls back to localhost:4318, fails with ECONNREFUSED on teardown, and the entire test run exits with code 1 — even though all tests passed.

  • vitest.node.otel.js: Export a Proxy wrapping the SDK instead of the raw instance. Intercepts shutdown() and forceFlush() to catch and warn on errors rather than propagate them. All other SDK method/property access is forwarded transparently via Reflect.get.

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: peter-leonov-ch <209667683+peter-leonov-ch@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 15, 2026

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • vitest.dev
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node /home/REDACTED/work/_temp/ghcca-node/node/bin/node --enable-source-maps /home/REDACTED/work/_temp/copilot-developer-action-main/dist/index.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Bump dev-dependencies group across 1 directory with 15 updates Fix OTEL SDK teardown errors breaking CI with vitest 4.1.0 Mar 15, 2026
Copilot AI requested a review from peter-leonov-ch March 15, 2026 20:37
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@peter-leonov-ch peter-leonov-ch marked this pull request as ready for review March 16, 2026 07:25
@peter-leonov-ch peter-leonov-ch merged commit a55ee13 into dependabot/npm_and_yarn/dev-dependencies-19b399dc78 Mar 16, 2026
56 checks passed
@peter-leonov-ch peter-leonov-ch deleted the copilot/sub-pr-610 branch March 16, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants