Backport #99042 to 26.2: Fix crash in CachedOnDiskReadBufferFromFile destructor#99235
Merged
clickhouse-gh[bot] merged 1 commit into26.2from Mar 11, 2026
Merged
Backport #99042 to 26.2: Fix crash in CachedOnDiskReadBufferFromFile destructor#99235clickhouse-gh[bot] merged 1 commit into26.2from
clickhouse-gh[bot] merged 1 commit into26.2from
Conversation
4012d39 to
7e85554
Compare
Contributor
|
Workflow [BackportPR], commit [7e85554] Summary: ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #99042
Cherry-pick pull-request #99234
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.
The PR source
The PR is created in the CI job
Note
Low Risk
Low risk: adds a null-check before using
stateduring destructor logging to prevent a crash; no behavior changes to caching or IO flow beyond skipping the log when state is unset.Overview
Fixes a destructor crash in
CachedOnDiskReadBufferFromFileby guarding filesystem cache log emission with an additionalstatecheck.If the buffer is destroyed before
stateis initialized, the destructor now skipsappendFilesystemCacheLog(...)instead of dereferencing a nullstate.Written by Cursor Bugbot for commit 7e85554. This will update automatically on new commits. Configure here.