Cherry pick #99042 to 26.2: Fix crash in CachedOnDiskReadBufferFromFile destructor#99234
Merged
robot-clickhouse merged 2 commits intobackport/26.2/99042from Mar 11, 2026
Merged
Conversation
Fix crash in CachedOnDiskReadBufferFromFile destructor
4012d39
into
backport/26.2/99042
129 of 130 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #99042
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job
Note
Low Risk
Low risk null-check fix: prevents a potential crash when destructor tries to log cache activity without an initialized
state. No behavior change beyond skipping the log record in that edge case.Overview
Prevents a crash in
CachedOnDiskReadBufferFromFiledestruction by only callingappendFilesystemCacheLog(...)whenstateis present, avoiding dereferencing a nullstatewhile still cleaning up/finishing any remaining file segments.Written by Cursor Bugbot for commit 587e799. This will update automatically on new commits. Configure here.