Fix flaky test test_many_connections in test_odbc_interaction#98362
Merged
alexey-milovidov merged 1 commit intomasterfrom Mar 1, 2026
Merged
Fix flaky test test_many_connections in test_odbc_interaction#98362alexey-milovidov merged 1 commit intomasterfrom
alexey-milovidov merged 1 commit intomasterfrom
Conversation
The `odbc-bridge` crashes with SIGSEGV when handling 25 concurrent requests simultaneously (each UNION ALL branch opens a separate HTTP connection to the bridge). The crash occurs in the thread pool when `ParallelFormattingOutputFormat` tries to spawn formatting threads for each concurrent request, causing resource exhaustion. After the crash, remaining connections get "Connection refused" and the query fails. Use `assert_eq_with_retry` (already used elsewhere in this test file) to retry the query. On retry, `startBridgeSync` detects the dead bridge and restarts it. Closes #92521 https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=93983&sha=fbe65318fd2687eb5640e14df6cd5cba1455cada&name_0=PR&name_1=Integration%20tests%20%28amd_binary%2C%203%2F5%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
alexey-milovidov
added a commit
that referenced
this pull request
Mar 1, 2026
…laky Fix flaky test test_many_connections in test_odbc_interaction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
odbc-bridgecrashes with SIGSEGV when handling 25 concurrent ODBC requests simultaneously, causing subsequent connections to get "Connection refused"assert_eq_with_retryto retry the query, allowingstartBridgeSyncto detect the dead bridge and restart it on retryCI report: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=93983&sha=fbe65318fd2687eb5640e14df6cd5cba1455cada&name_0=PR&name_1=Integration%20tests%20%28amd_binary%2C%203%2F5%29
Closes #92521
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Documentation entry for user-facing changes
🤖 Generated with Claude Code