Skip to content

Allow Bug Fix PRs without new tests if PR has a CI report link#97565

Merged
alexey-milovidov merged 1 commit intomasterfrom
allow-bugfix-pr-with-ci-report-link
Feb 21, 2026
Merged

Allow Bug Fix PRs without new tests if PR has a CI report link#97565
alexey-milovidov merged 1 commit intomasterfrom
allow-bugfix-pr-with-ci-report-link

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Summary

  • The "Finish workflow" check requires Bug Fix PRs to include new or changed tests
  • This is too strict for PRs that fix CI failures — the existing CI already serves as the test
  • Allow the check to pass if the PR description contains a link to a CI report (s3.amazonaws.com/clickhouse-test-reports)
  • Example PR that would benefit: Fix data race on shutdown_called in DatabaseMaterializedPostgreSQL #97554

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

🤖 Generated with Claude Code

… link

The "Finish workflow" check requires Bug Fix PRs to include new or
changed tests. This is too strict for PRs that fix CI failures, where
the existing CI already serves as the test. Allow the check to pass
if the PR description contains a link to a CI report
(`s3.amazonaws.com/clickhouse-test-reports`), e.g. as in
#97554

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Feb 21, 2026

Workflow [PR], commit [18a973e]

Summary:

@clickhouse-gh clickhouse-gh bot added the pr-ci label Feb 21, 2026
@alexey-milovidov alexey-milovidov self-assigned this Feb 21, 2026
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Feb 21, 2026
Merged via the queue into master with commit 906ae6f Feb 21, 2026
148 checks passed
@alexey-milovidov alexey-milovidov deleted the allow-bugfix-pr-with-ci-report-link branch February 21, 2026 14:36
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 21, 2026
Algunenano pushed a commit to Algunenano/ClickHouse that referenced this pull request Feb 24, 2026
…ith-ci-report-link

Allow Bug Fix PRs without new tests if PR has a CI report link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants