Skip to content

Fix readonlyness of encrypted disks#94852

Merged
azat merged 3 commits intoClickHouse:masterfrom
azat:fix-encrypted-disk-ro
Jan 23, 2026
Merged

Fix readonlyness of encrypted disks#94852
azat merged 3 commits intoClickHouse:masterfrom
azat:fix-encrypted-disk-ro

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 22, 2026

Note, this is only minimal fix for backport, later I will submit cleanup of IDisk

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix readonlyness of encrypted disks

@azat azat requested a review from yariks5s January 22, 2026 16:55
@yariks5s yariks5s self-assigned this Jan 22, 2026
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 22, 2026 •
edited
Loading

Workflow [PR], commit [a599c58]

Summary: ❌

job_name test_name status info comment
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue
BuzzHouse (amd_ubsan) failure
Logical error: Cannot find transaction A that has started mutation B that is going to be applied to part C (STID: 3968-4fab) FAIL cidb, issue
BuzzHouse (arm_asan) error

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 22, 2026
@azat azat added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jan 22, 2026
azat added 2 commits January 22, 2026 18:34
@azat
Implement getObjectStorage() for DiskEncrypted
b09849f 
Now, since it passes through other methods it needs this one as well
@azat
Allow encrypted disks over plain rewritable again
a599c58
@azat azat enabled auto-merge January 23, 2026 14:48
@azat azat added this pull request to the merge queue Jan 23, 2026
Merged via the queue into ClickHouse:master with commit 253f8ee Jan 23, 2026
130 of 134 checks passed
@azat azat deleted the fix-encrypted-disk-ro branch January 23, 2026 15:44
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 23, 2026
This was referenced Jan 23, 2026
Closed
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jan 23, 2026
@robot-clickhouse-ci-2
Merge pull request #94991 from ClickHouse/cherrypick/25.10/94852
487ea0a 
Cherry pick #94852 to 25.10: Fix readonlyness of encrypted disks
robot-clickhouse added a commit that referenced this pull request Jan 23, 2026
@robot-clickhouse
Backport #94852 to 25.10: Fix readonlyness of encrypted disks
93c0cd2
This was referenced Jan 23, 2026
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jan 23, 2026
@robot-clickhouse-ci-2
Merge pull request #94993 from ClickHouse/cherrypick/25.11/94852
7f3056b 
Cherry pick #94852 to 25.11: Fix readonlyness of encrypted disks
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 23, 2026
robot-clickhouse added a commit that referenced this pull request Jan 23, 2026
@robot-clickhouse
Backport #94852 to 25.11: Fix readonlyness of encrypted disks
a89c0e0
This was referenced Jan 23, 2026
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Jan 23, 2026
@robot-clickhouse-ci-2
Merge pull request #94995 from ClickHouse/cherrypick/25.12/94852
dbc3463 
Cherry pick #94852 to 25.12: Fix readonlyness of encrypted disks
robot-clickhouse added a commit that referenced this pull request Jan 23, 2026
@robot-clickhouse
Backport #94852 to 25.12: Fix readonlyness of encrypted disks
95bda76
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Jan 23, 2026
Merged
azat added a commit that referenced this pull request Jan 24, 2026
@azat
Merge pull request #94997 from ClickHouse/backport/25.12/94852
f2dd3fc 
Backport #94852 to 25.12: Fix readonlyness of encrypted disks
azat added a commit that referenced this pull request Jan 24, 2026
@azat
Merge pull request #94994 from ClickHouse/backport/25.11/94852
5802cdb 
Backport #94852 to 25.11: Fix readonlyness of encrypted disks
robot-ch-test-poll added a commit that referenced this pull request Jan 24, 2026
@robot-ch-test-poll
Merge pull request #94990 from ClickHouse/cherrypick/25.8/94852
5102ab7 
Cherry pick #94852 to 25.8: Fix readonlyness of encrypted disks
robot-clickhouse added a commit that referenced this pull request Jan 24, 2026
@robot-clickhouse
Backport #94852 to 25.8: Fix readonlyness of encrypted disks
d69c4eb
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Jan 24, 2026
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 24, 2026
azat added a commit that referenced this pull request Jan 26, 2026
@azat
Merge pull request #94992 from ClickHouse/backport/25.10/94852
3257c40 
Backport #94852 to 25.10: Fix readonlyness of encrypted disks
azat added a commit that referenced this pull request Jan 28, 2026
@azat
Merge pull request #95059 from ClickHouse/backport/25.8/94852
44d2c8a 
Backport #94852 to 25.8: Fix readonlyness of encrypted disks
azat added a commit to azat/ClickHouse that referenced this pull request Jan 28, 2026
@azat
Fix check for encrypted disks over plain_rewritable
7dbd005 
Previously if you have two encrypted disks points to the same
plain_rewritable, i.e. one over cache and one not, you will get "It is
not possible to register multiple plain-rewritable disks with the same
object storage prefix".

Fixes: ClickHouse#94852
@azat azat mentioned this pull request Jan 28, 2026
Merged
azat added a commit to azat/ClickHouse that referenced this pull request Jan 29, 2026
@azat
Fix check for encrypted disks over plain_rewritable
cf85a1c 
Previously if you have two encrypted disks points to the same
plain_rewritable, i.e. one over cache and one not, you will get "It is
not possible to register multiple plain-rewritable disks with the same
object storage prefix".

Fixes: ClickHouse#94852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yariks5s yariks5s yariks5s approved these changes

Assignees

@yariks5s yariks5s

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@azat @yariks5s @robot-ch-test-poll @robot-clickhouse-ci-2