Skip to content

Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges#94725

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:fix-const-granularity-after-vertical-merge
Jan 22, 2026
Merged

Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges#94725
azat merged 1 commit intoClickHouse:masterfrom
azat:fix-const-granularity-after-vertical-merge

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Jan 21, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges

The problem was that just before creating index granularity the blocks_are_granules_size has been set to true in case of vertical merges, and this forces to use adaptive granulas

But, we do not need this, since it is written before vertical merges anyway, vertical merges does not calculate index granularity

@azat azat requested a review from CurtizJ January 21, 2026 13:06
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 21, 2026

Workflow [PR], commit [86fcd89]

Summary:

job_name test_name status info comment
Stateless tests (amd_tsan, sequential, 1/2) failure
03760_backup_tar_archive FAIL cidb IGNORED
ThreadSanitizer: data race (STID: 2981-3c7d) FAIL cidb, issue ISSUE CREATED

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Jan 21, 2026
@CurtizJ CurtizJ self-assigned this Jan 21, 2026
@azat azat force-pushed the fix-const-granularity-after-vertical-merge branch from 742efd8 to 53897db Compare January 21, 2026 14:11
@azat azat enabled auto-merge January 21, 2026 14:44
@azat azat added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Jan 21, 2026
…after Vertical merges

The problem was that just before creating index granularity the
blocks_are_granules_size has been set to true in case of vertical
merges, and this forces to use adaptive granulas

But, we do not need this, since it is written before vertical merges
anyway, vertical merges does not calculate index granularity
@azat azat force-pushed the fix-const-granularity-after-vertical-merge branch from 53897db to 86fcd89 Compare January 21, 2026 23:10
@azat azat added this pull request to the merge queue Jan 22, 2026
Merged via the queue into ClickHouse:master with commit e3bc468 Jan 22, 2026
130 of 132 checks passed
@azat azat deleted the fix-const-granularity-after-vertical-merge branch January 22, 2026 07:35
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jan 22, 2026
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jan 22, 2026
robot-ch-test-poll1 added a commit that referenced this pull request Jan 22, 2026
Cherry pick #94725 to 25.8: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
…st_adaptive_granularity) after Vertical merges
robot-ch-test-poll1 added a commit that referenced this pull request Jan 22, 2026
Cherry pick #94725 to 25.10: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
…nst_adaptive_granularity) after Vertical merges
robot-ch-test-poll1 added a commit that referenced this pull request Jan 22, 2026
Cherry pick #94725 to 25.11: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
…nst_adaptive_granularity) after Vertical merges
robot-ch-test-poll1 added a commit that referenced this pull request Jan 22, 2026
Cherry pick #94725 to 25.12: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
…nst_adaptive_granularity) after Vertical merges
clickhouse-gh bot added a commit that referenced this pull request Jan 22, 2026
Backport #94725 to 25.12: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
robot-ch-test-poll3 added a commit that referenced this pull request Jan 22, 2026
Cherry pick #94725 to 25.3: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
…st_adaptive_granularity) after Vertical merges
clickhouse-gh bot added a commit that referenced this pull request Jan 22, 2026
Backport #94725 to 25.10: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 22, 2026
clickhouse-gh bot added a commit that referenced this pull request Jan 22, 2026
Backport #94725 to 25.11: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
clickhouse-gh bot added a commit that referenced this pull request Jan 22, 2026
Backport #94725 to 25.8: Preserve constant index granularity (use_const_adaptive_granularity) after Vertical merges
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants