Fix incorrect RIGHT join result when using complex ON conditions#94680
Merged
Fix incorrect RIGHT join result when using complex ON conditions#94680
Conversation
Contributor
|
Workflow [PR], commit [dbf74c9] Summary: ❌
|
e35f5a3 to
dbf74c9
Compare
novikd
reviewed
Jan 21, 2026
| SELECT | ||
| * | ||
| FROM t1 | ||
| RIGHT JOIN t0 |
Member
There was a problem hiding this comment.
Let's add queries with LEFT JOIN from the issue as well.
Member
Author
There was a problem hiding this comment.
Thanks for the suggestion! I took a look, and queries using LEFT JOIN return the correct results (unless they’re rewritten to RIGHT JOIN depending on query_plan_join_swap_table, what happened in query from the issue). Since this PR is specifically fixing the RIGHT JOIN behavior, adding LEFT JOIN cases wouldn’t actually cover any of the code paths changed here.
If you still think adding LEFT JOIN cases would be useful for completeness, I’m happy to do that in a follow-up PR. That way we can merge this fix without waiting on another CI run, which might be helpful given the upcoming release.
Comment on lines
54
to
+60
| per_row_flags[columns] = std::vector<std::atomic_bool>(columns->at(0)->size()); | ||
|
|
||
| /// Mark all rows outside of selector as used. | ||
| /// We should not emit them in RIGHT/FULL JOIN result, | ||
| /// since they belongs to another shard, which will handle flags for these rows | ||
| for (auto & flag : per_row_flags[columns]) | ||
| flag.store(true); |
Member
There was a problem hiding this comment.
Suggested change
| per_row_flags[columns] = std::vector<std::atomic_bool>(columns->at(0)->size()); | |
| /// Mark all rows outside of selector as used. | |
| /// We should not emit them in RIGHT/FULL JOIN result, | |
| /// since they belongs to another shard, which will handle flags for these rows | |
| for (auto & flag : per_row_flags[columns]) | |
| flag.store(true); | |
| /// Mark all rows outside of selector as used. | |
| /// We should not emit them in RIGHT/FULL JOIN result, | |
| /// since they belongs to another shard, which will handle flags for these rows | |
| per_row_flags[columns] = std::vector<std::atomic_bool>(columns->at(0)->size(), true); |
This was referenced Jan 22, 2026
Merged
Merged
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 22, 2026
Cherry pick #94680 to 25.10: Fix incorrect RIGHT join result when using complex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
…complex ON conditions
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 22, 2026
Cherry pick #94680 to 25.11: Fix incorrect RIGHT join result when using complex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
…complex ON conditions
robot-ch-test-poll1
added a commit
that referenced
this pull request
Jan 22, 2026
Cherry pick #94680 to 25.12: Fix incorrect RIGHT join result when using complex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
…complex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
Cherry pick #94680 to 25.3: Fix incorrect RIGHT join result when using complex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
…omplex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
Cherry pick #94680 to 25.8: Fix incorrect RIGHT join result when using complex ON conditions
robot-clickhouse
added a commit
that referenced
this pull request
Jan 22, 2026
…omplex ON conditions
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 22, 2026
Backport #94680 to 25.12: Fix incorrect RIGHT join result when using complex ON conditions
vdimir
added a commit
that referenced
this pull request
Jan 23, 2026
Backport #94680 to 25.10: Fix incorrect RIGHT join result when using complex ON conditions
vdimir
added a commit
that referenced
this pull request
Jan 23, 2026
Backport #94680 to 25.11: Fix incorrect RIGHT join result when using complex ON conditions
vdimir
added a commit
that referenced
this pull request
Jan 23, 2026
Backport #94680 to 25.8: Fix incorrect RIGHT join result when using complex ON conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
query_plan_filter_push_downvalue #92913