Skip to content

fix segfault in DeltaLakeMetadata::getFieldValue#94627

Merged
mstetsyuk merged 2 commits intomasterfrom
fix-segfault-in-DeltaLakeMetadata-getFieldValue
Jan 22, 2026
Merged

fix segfault in DeltaLakeMetadata::getFieldValue#94627
mstetsyuk merged 2 commits intomasterfrom
fix-segfault-in-DeltaLakeMetadata-getFieldValue

Conversation

@mstetsyuk
Copy link
Copy Markdown
Member

@mstetsyuk mstetsyuk commented Jan 19, 2026

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixes https://github.com/ClickHouse/clickhouse-core-incidents/issues/1250. Likely due to a mix-up, data_type (which may be DataTypeNullable*) is static_cast-ed to DataTypeDateTime64*. Instead, we should cast check_type (the nested type variable).

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Jan 19, 2026 •
edited
Loading

Workflow [PR], commit [f0476d0]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_tsan, s3 storage, parallel) failure
03562_parallel_replicas_remote_with_cluster FAIL cidb, issue
Integration tests (arm_binary, distributed plan, 1/4) failure
test_max_temporary_data_size_on_disk/test.py::test FAIL cidb, issue
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL cidb, issue

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Jan 19, 2026
@SmitaRKulkarni SmitaRKulkarni self-assigned this Jan 20, 2026
@mstetsyuk mstetsyuk added this pull request to the merge queue Jan 22, 2026
Merged via the queue into master with commit a1f135b Jan 22, 2026
128 of 132 checks passed
@mstetsyuk mstetsyuk deleted the fix-segfault-in-DeltaLakeMetadata-getFieldValue branch January 22, 2026 13:38
@robot-ch-test-poll3 robot-ch-test-poll3 added pr-synced-to-cloud The PR is synced to the cloud repo pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR labels Jan 22, 2026
This was referenced Jan 22, 2026
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Merge pull request #94839 from ClickHouse/cherrypick/25.8/94627
5d76d36 
Cherry pick #94627 to 25.8: fix segfault in DeltaLakeMetadata::getFieldValue
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Backport #94627 to 25.8: fix segfault in DeltaLakeMetadata::getFieldV…
ea5e694 
…alue
This was referenced Jan 22, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Merge pull request #94841 from ClickHouse/cherrypick/25.10/94627
7eba059 
Cherry pick #94627 to 25.10: fix segfault in DeltaLakeMetadata::getFieldValue
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Backport #94627 to 25.10: fix segfault in DeltaLakeMetadata::getField…
18955b0 
…Value
This was referenced Jan 22, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Merge pull request #94843 from ClickHouse/cherrypick/25.11/94627
2425d32 
Cherry pick #94627 to 25.11: fix segfault in DeltaLakeMetadata::getFieldValue
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Backport #94627 to 25.11: fix segfault in DeltaLakeMetadata::getField…
9b417ff 
…Value
This was referenced Jan 22, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Merge pull request #94845 from ClickHouse/cherrypick/25.12/94627
abe4827 
Cherry pick #94627 to 25.12: fix segfault in DeltaLakeMetadata::getFieldValue
robot-clickhouse added a commit that referenced this pull request Jan 22, 2026
@robot-clickhouse
Backport #94627 to 25.12: fix segfault in DeltaLakeMetadata::getField…
bcad084 
…Value
@robot-clickhouse robot-clickhouse mentioned this pull request Jan 22, 2026
Merged
clickhouse-gh bot added a commit that referenced this pull request Jan 22, 2026
@clickhouse-gh
Merge pull request #94844 from ClickHouse/backport/25.11/94627
6bca76e 
Backport #94627 to 25.11: fix segfault in DeltaLakeMetadata::getFieldValue
clickhouse-gh bot added a commit that referenced this pull request Jan 22, 2026
@clickhouse-gh
Merge pull request #94840 from ClickHouse/backport/25.8/94627
5184693 
Backport #94627 to 25.8: fix segfault in DeltaLakeMetadata::getFieldValue
mstetsyuk added a commit that referenced this pull request Jan 23, 2026
@mstetsyuk
Merge pull request #94846 from ClickHouse/backport/25.12/94627
dddf8ba 
Backport #94627 to 25.12: fix segfault in DeltaLakeMetadata::getFieldValue
mstetsyuk added a commit that referenced this pull request Jan 23, 2026
@mstetsyuk
Merge pull request #94842 from ClickHouse/backport/25.10/94627
1f08641 
Backport #94627 to 25.10: fix segfault in DeltaLakeMetadata::getFieldValue
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 23, 2026
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kssenii kssenii kssenii approved these changes

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mstetsyuk @kssenii @SmitaRKulkarni @robot-ch-test-poll4 @robot-ch-test-poll3