Fix join with StorageJoin with USING clause#94000
Merged
Conversation
Contributor
|
Workflow [PR], commit [c5406fc] Summary: ❌
|
vdimir
approved these changes
Jan 16, 2026
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 19, 2026
Cherry pick #94000 to 25.10: Fix join with StorageJoin with USING clause
robot-clickhouse
added a commit
that referenced
this pull request
Jan 19, 2026
This was referenced Jan 19, 2026
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 19, 2026
Cherry pick #94000 to 25.11: Fix join with StorageJoin with USING clause
robot-clickhouse
added a commit
that referenced
this pull request
Jan 19, 2026
This was referenced Jan 19, 2026
robot-ch-test-poll
added a commit
that referenced
this pull request
Jan 19, 2026
Cherry pick #94000 to 25.12: Fix join with StorageJoin with USING clause
robot-clickhouse
added a commit
that referenced
this pull request
Jan 19, 2026
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 19, 2026
Backport #94000 to 25.12: Fix join with StorageJoin with USING clause
novikd
added a commit
that referenced
this pull request
Jan 21, 2026
Backport #94000 to 25.11: Fix join with StorageJoin with USING clause
clickhouse-gh bot
added a commit
that referenced
this pull request
Jan 22, 2026
Backport #94000 to 25.10: Fix join with StorageJoin with USING clause
alexey-milovidov
added a commit
that referenced
this pull request
Feb 8, 2026
…n path The legacy join planning path (`query_plan_use_new_logical_join_step` = 0) did not add type conversion for right-side USING columns after `FilledJoinStep`. The pre-join cast on `right_plan` was ineffective because filled joins (`StorageJoin`) don't use `right_plan` data — it comes directly from storage. This caused downstream steps (e.g., QUALIFY filter) to see the original storage type (`UInt32`) instead of the expected USING super type (`Nullable(UInt32)`), triggering: Logical error: 'Unexpected return type from equals. Expected Nullable(UInt8). Got UInt8.' The new logical join step path already handled this (PR #94000) by adding "Right Type Conversion Actions". Apply the same conversion in the legacy path. https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=96359&sha=2663a0412e2c5796633875276ad818515e5f5e2d&name_0=PR&name_1=Stress%20test%20%28amd_debug%29 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix type conversion to super type during the join operation of the storage
JoinwithUSINGclause. Fixes #91672. Fixes #78572.Documentation entry for user-facing changes
Close #94406