Conversation
Contributor
|
|
307cc16 to
4e0e90f
Compare
alexbakharew
commented
Jan 14, 2026
alexbakharew
commented
Jan 14, 2026
azat
requested changes
Jan 14, 2026
Member
azat
left a comment
There was a problem hiding this comment.
In general this is correct fix, but remove all unrelated changes, and I will look one more time
azat
reviewed
Jan 15, 2026
src/Server/TCPHandler.cpp
Outdated
| sendProfileInfo(state, executor.getProfileInfo()); | ||
| sendProgress(state); | ||
| sendLogs(state); | ||
| /// Do it before sending end of stream, to have a chance to show log message in client. |
Member
There was a problem hiding this comment.
The comment is outdated, it should reflect why it is done here for SELECT
But what is more importantly, why we are doing it only for SELECT?
Let's do the following: do this for all queries, and rely on logging from dtor of query scope in case of exception, then we can remove this extra bool flag
And this should be enough for now.
Also note, that the still can be some drift actually (it is just a matter of do we have allocations between sending profile events this log)
So, if the test will be flaky after we can do the following:
- make the comparsion less strict
- use more complex query, so that allocations here will not update peak (since it will use more memory before)
- remove the test
azat
reviewed
Jan 15, 2026
925831d to
f498ca4
Compare
f498ca4 to
48eb641
Compare
azat
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes: #90840