Skip to content

Fix crashes in merge of text indexes#92925

Merged
CurtizJ merged 3 commits intoClickHouse:masterfrom
CurtizJ:fix-text-index-vertical-merge
Dec 23, 2025
Merged

Fix crashes in merge of text indexes#92925
CurtizJ merged 3 commits intoClickHouse:masterfrom
CurtizJ:fix-text-index-vertical-merge

Conversation

@CurtizJ
Copy link
Copy Markdown
Member

@CurtizJ CurtizJ commented Dec 23, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fixed several crashes during merges of text indexes in MergeTree tables.

Fixes #92915.
Fixes #92919.
Fixes #92921.

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 23, 2025 •
edited by CurtizJ
Loading

Workflow [PR], commit [657b885]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel) failure
02319_lightweight_delete_on_merge_tree FAIL issue ISSUE EXISTS
Stateless tests (amd_debug, distributed plan, s3 storage, parallel) failure
02319_lightweight_delete_on_merge_tree FAIL issue ISSUE EXISTS
Integration tests (amd_binary, 4/5) failure
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3_always_multi_part] FAIL IGNORED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting: the query: (STID: 1941-1bfa) FAIL issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Dec 23, 2025
@CurtizJ CurtizJ force-pushed the fix-text-index-vertical-merge branch from 2c1c478 to 134b7ea Compare December 23, 2025 17:42
@CurtizJ CurtizJ changed the title Fix vertical merge with text index Fix crashes in merge of text indexes Dec 23, 2025
@CurtizJ CurtizJ self-assigned this Dec 23, 2025
@CurtizJ CurtizJ added this pull request to the merge queue Dec 23, 2025
Merged via the queue into ClickHouse:master with commit 7b9c8d9 Dec 23, 2025
126 of 131 checks passed
@CurtizJ CurtizJ deleted the fix-text-index-vertical-merge branch December 23, 2025 23:18
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 23, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Dec 24, 2025
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Dec 24, 2025
Merged
robot-ch-test-poll added a commit that referenced this pull request Dec 24, 2025
@robot-ch-test-poll
Merge pull request #92968 from ClickHouse/cherrypick/25.12/92925
8291e28 
Cherry pick #92925 to 25.12: Fix crashes in merge of text indexes
robot-clickhouse added a commit that referenced this pull request Dec 24, 2025
@robot-clickhouse
Backport #92925 to 25.12: Fix crashes in merge of text indexes
75d7603
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Dec 24, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 24, 2025
CurtizJ added a commit that referenced this pull request Dec 24, 2025
@CurtizJ
Merge pull request #92969 from ClickHouse/backport/25.12/92925
e1a72d7 
Backport #92925 to 25.12: Fix crashes in merge of text indexes
@ahmadov ahmadov self-assigned this Mar 4, 2026
@ahmadov ahmadov added the post-approved Approved, but after the PR is merged. label Mar 11, 2026
clickgapai added a commit to clickgapai/ClickHouse that referenced this pull request Mar 29, 2026
@clickgapai
Add 1 test(s) for coverage gaps in PR ClickHouse#92925
0006765
@clickgapai clickgapai mentioned this pull request Mar 29, 2026
Merged
1 task
@clickgapai
Copy link
Copy Markdown
Contributor

clickgapai commented Mar 29, 2026

Hi @CurtizJ — while reviewing this PR I found the following:

Could you review the test PR and add the can be tested label if it looks good?
Happy to discuss — close anything that's wrong or already addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ahmadov ahmadov

@CurtizJ CurtizJ

Labels

post-approved Approved, but after the PR is merged. pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo v25.12-must-backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: '!finalized' Logical error: 'page_pos < pages.size()' with text index Crash during merges

7 participants

@CurtizJ @clickgapai @ahmadov @robot-ch-test-poll3 @rschu1ze @robot-clickhouse-ci-1 @robot-clickhouse-ci-2