Skip to content

Inherit source part serialization info settings during mutation in MergeTree#92419

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fix-serialization-settings-in-mutation
Dec 18, 2025
Merged

Inherit source part serialization info settings during mutation in MergeTree#92419
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fix-serialization-settings-in-mutation

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Dec 17, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Inherit source part serialization info settings during mutation in MergeTree. It fixes possible incorrect result of the query over mutated part after changes in data types serialization.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 17, 2025 •
edited by Avogar
Loading

Workflow [PR], commit [b4e3dac]

Summary: ❌

job_name test_name status info comment
Integration tests (amd_asan, db disk, old analyzer, 5/6) failure
test_external_http_authenticator/test.py::test_user_from_config_basic_auth_pass FAIL cidb IGNORED
test_external_http_authenticator/test.py::test_user_create_basic_auth_pass FAIL cidb IGNORED
test_external_http_authenticator/test.py::test_basic_auth_failed FAIL cidb IGNORED
test_external_http_authenticator/test.py::test_header_failed FAIL cidb IGNORED
test_external_http_authenticator/test.py::test_session_settings_from_auth_response FAIL cidb IGNORED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting in Function_divide: the query: (STID: 1941-1bfa) FAIL cidb, issue ISSUE EXISTS

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Dec 17, 2025
@kssenii kssenii self-assigned this Dec 17, 2025
azat
azat reviewed Dec 17, 2025
View reviewed changes
@Avogar Avogar added this pull request to the merge queue Dec 18, 2025
Merged via the queue into ClickHouse:master with commit 602d17f Dec 18, 2025
128 of 131 checks passed
@Avogar Avogar deleted the fix-serialization-settings-in-mutation branch December 18, 2025 14:45
@robot-clickhouse robot-clickhouse added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 18, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Dec 18, 2025
This was referenced Dec 18, 2025
Closed
Closed
Closed
Merged
Merged
Merged
robot-ch-test-poll1 added a commit that referenced this pull request Dec 18, 2025
@robot-ch-test-poll1
Merge pull request #92548 from ClickHouse/cherrypick/25.12/92419
c6428da 
Cherry pick #92419 to 25.12: Inherit source part serialization info settings during mutation in MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 18, 2025
@robot-clickhouse
Backport #92419 to 25.12: Inherit source part serialization info sett…
a8e6f7c 
…ings during mutation in MergeTree
@robot-ch-test-poll1 robot-ch-test-poll1 mentioned this pull request Dec 18, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Dec 18, 2025
@clickhouse-gh
Merge pull request #92549 from ClickHouse/backport/25.12/92419
8d51994 
Backport #92419 to 25.12: Inherit source part serialization info settings during mutation in MergeTree
robot-ch-test-poll2 added a commit that referenced this pull request Dec 19, 2025
@robot-ch-test-poll2
Merge pull request #92546 from ClickHouse/cherrypick/25.10/92419
330d89c 
Cherry pick #92419 to 25.10: Inherit source part serialization info settings during mutation in MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 19, 2025
@robot-clickhouse
Backport #92419 to 25.10: Inherit source part serialization info sett…
391d700 
…ings during mutation in MergeTree
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Dec 19, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Dec 19, 2025
@robot-ch-test-poll2
Merge pull request #92547 from ClickHouse/cherrypick/25.11/92419
b5a607c 
Cherry pick #92419 to 25.11: Inherit source part serialization info settings during mutation in MergeTree
robot-clickhouse added a commit that referenced this pull request Dec 19, 2025
@robot-clickhouse
Backport #92419 to 25.11: Inherit source part serialization info sett…
2f81f9a 
…ings during mutation in MergeTree
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Dec 19, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 19, 2025
clickhouse-gh bot added a commit that referenced this pull request Dec 19, 2025
@clickhouse-gh
Merge pull request #92673 from ClickHouse/backport/25.10/92419
dc721c5 
Backport #92419 to 25.10: Inherit source part serialization info settings during mutation in MergeTree
Avogar added a commit that referenced this pull request Dec 22, 2025
@Avogar
Merge pull request #92674 from ClickHouse/backport/25.11/92419
771b95d 
Backport #92419 to 25.11: Inherit source part serialization info settings during mutation in MergeTree
@Avogar Avogar mentioned this pull request Dec 24, 2025
Merged
1 task
@mlex mlex mentioned this pull request Jan 5, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat left review comments

@kssenii kssenii kssenii approved these changes

Assignees

@kssenii kssenii

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Avogar @azat @kssenii @mlex @robot-clickhouse @robot-ch-test-poll1