Skip to content

Fix possible logical error in Log engine during subcolumns reading#91711

Merged
Avogar merged 3 commits intoClickHouse:masterfrom
Avogar:fix-log-engine-perfix
Dec 18, 2025
Merged

Fix possible logical error in Log engine during subcolumns reading#91711
Avogar merged 3 commits intoClickHouse:masterfrom
Avogar:fix-log-engine-perfix

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Dec 8, 2025

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix possible logical error in Log engine during subcolumns reading. Closes #91710

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Dec 8, 2025 •
edited by Avogar
Loading

Workflow [PR], commit [eed3ccb]

Summary: ❌

job_name test_name status info comment
Bugfix validation (functional tests) failure
03753_log_engine_shared_prefixes_bug FAIL cidb IGNORED
Stateless tests (amd_asan, distributed plan, parallel, 2/2) failure
01304_direct_io_long FAIL cidb IGNORED
Stateless tests (arm_binary, parallel) failure
01287_max_execution_speed FAIL cidb, issue ISSUE EXISTS
Integration tests (amd_binary, 5/5) failure
test_odbc_interaction/test.py::test_many_connections FAIL cidb, issue ISSUE CREATED
BuzzHouse (amd_debug) failure
Logical error: 'Inconsistent AST formatting in Function_arrayElement: the query: FAIL cidb IGNORED
BuzzHouse (arm_asan) failure
Logical error: Unexpected return type from A. Expected B. Got C. Action: FAIL cidb, issue ISSUE EXISTS
BuzzHouse (amd_ubsan) failure
UndefinedBehaviorSanitizer: undefined behavior (STID: 4443-3aa0) FAIL cidb IGNORED

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Dec 8, 2025
@SmitaRKulkarni SmitaRKulkarni self-assigned this Dec 9, 2025
SmitaRKulkarni
SmitaRKulkarni reviewed Dec 9, 2025
View reviewed changes
SmitaRKulkarni
SmitaRKulkarni approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Avogar Avogar added this pull request to the merge queue Dec 18, 2025
Merged via the queue into ClickHouse:master with commit 61fc66e Dec 18, 2025
122 of 130 checks passed
@Avogar Avogar deleted the fix-log-engine-perfix branch December 18, 2025 14:03
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Dec 18, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 18, 2025
This was referenced Dec 18, 2025
Merged
Merged
Closed
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 18, 2025
@robot-ch-test-poll3
Merge pull request #92529 from ClickHouse/cherrypick/25.11/91711
1eb9c9d 
Cherry pick #91711 to 25.11: Fix possible logical error in Log engine during subcolumns reading
robot-clickhouse added a commit that referenced this pull request Dec 18, 2025
@robot-clickhouse
Backport #91711 to 25.11: Fix possible logical error in Log engine du…
a39b9c5 
…ring subcolumns reading
This was referenced Dec 18, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Dec 18, 2025
@robot-ch-test-poll3
Merge pull request #92531 from ClickHouse/cherrypick/25.12/91711
f7b721a 
Cherry pick #91711 to 25.12: Fix possible logical error in Log engine during subcolumns reading
robot-clickhouse added a commit that referenced this pull request Dec 18, 2025
@robot-clickhouse
Backport #91711 to 25.12: Fix possible logical error in Log engine du…
a61ef30 
…ring subcolumns reading
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Dec 18, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Dec 18, 2025
@clickhouse-gh
Merge pull request #92532 from ClickHouse/backport/25.12/91711
b03ae3d 
Backport #91711 to 25.12: Fix possible logical error in Log engine during subcolumns reading
Avogar added a commit that referenced this pull request Dec 19, 2025
@Avogar
Merge pull request #92530 from ClickHouse/backport/25.11/91711
9142cca 
Backport #91711 to 25.11: Fix possible logical error in Log engine during subcolumns reading
robot-ch-test-poll2 added a commit that referenced this pull request Dec 19, 2025
@robot-ch-test-poll2
Merge pull request #92525 from ClickHouse/cherrypick/25.3/91711
0a8ac53 
Cherry pick #91711 to 25.3: Fix possible logical error in Log engine during subcolumns reading
robot-clickhouse added a commit that referenced this pull request Dec 19, 2025
@robot-clickhouse
Backport #91711 to 25.3: Fix possible logical error in Log engine dur…
5181529 
…ing subcolumns reading
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Dec 19, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Dec 19, 2025
@robot-ch-test-poll2
Merge pull request #92526 from ClickHouse/cherrypick/25.8/91711
d8b9a41 
Cherry pick #91711 to 25.8: Fix possible logical error in Log engine during subcolumns reading
robot-clickhouse added a commit that referenced this pull request Dec 19, 2025
@robot-clickhouse
Backport #91711 to 25.8: Fix possible logical error in Log engine dur…
69d3042 
…ing subcolumns reading
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Dec 19, 2025
Merged
robot-ch-test-poll2 added a commit that referenced this pull request Dec 19, 2025
@robot-ch-test-poll2
Merge pull request #92528 from ClickHouse/cherrypick/25.10/91711
5e8bddf 
Cherry pick #91711 to 25.10: Fix possible logical error in Log engine during subcolumns reading
robot-clickhouse added a commit that referenced this pull request Dec 19, 2025
@robot-clickhouse
Backport #91711 to 25.10: Fix possible logical error in Log engine du…
a275b28 
…ring subcolumns reading
@robot-ch-test-poll2 robot-ch-test-poll2 mentioned this pull request Dec 19, 2025
Merged
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 19, 2025
Avogar added a commit that referenced this pull request Dec 23, 2025
@Avogar
Merge pull request #92691 from ClickHouse/backport/25.10/91711
af2c746 
Backport #91711 to 25.10: Fix possible logical error in Log engine during subcolumns reading
Avogar added a commit that referenced this pull request Dec 29, 2025
@Avogar
Merge pull request #92690 from ClickHouse/backport/25.8/91711
b426f8a 
Backport #91711 to 25.8: Fix possible logical error in Log engine during subcolumns reading
Avogar added a commit that referenced this pull request Dec 29, 2025
@Avogar
Merge pull request #92689 from ClickHouse/backport/25.3/91711
4772f81 
Backport #91711 to 25.3: Fix possible logical error in Log engine during subcolumns reading
@alexey-milovidov alexey-milovidov mentioned this pull request Feb 7, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: '(isConst() || isSparse() || isReplicated()) ? getDataType() == rhs.getDataType() : typeid(*this) == typeid(rhs)' (STID: 2508-35cc)

4 participants

@Avogar @SmitaRKulkarni @robot-ch-test-poll1 @robot-ch-test-poll4