Skip to content

Show datalake catalogs in SHOW DATABASES query#89914

Merged
alesapin merged 1 commit intomasterfrom
show_catalogs_in_show_databses
Nov 12, 2025
Merged

Show datalake catalogs in SHOW DATABASES query#89914
alesapin merged 1 commit intomasterfrom
show_catalogs_in_show_databses

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Nov 12, 2025 •
edited by clickhouse-gh Bot
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Now ClickHouse will show data lake catalog database in SHOW DATABASES query by default.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@alesapin alesapin added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 12, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh Bot commented Nov 12, 2025 •
edited
Loading

Workflow [PR], commit [ee3d937]

Summary: ❌

job_name test_name status info comment
BuzzHouse (amd_debug) failure
Buzzing result failure cidb
BuzzHouse (amd_tsan) failure
Buzzing result failure cidb

@clickhouse-gh clickhouse-gh Bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 12, 2025
@alesapin
Copy link
Copy Markdown
Member Author

alesapin commented Nov 12, 2025

Followup to #88341

@alesapin alesapin mentioned this pull request Nov 12, 2025
Closed
@SmitaRKulkarni SmitaRKulkarni self-assigned this Nov 12, 2025
SmitaRKulkarni
SmitaRKulkarni approved these changes Nov 12, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SmitaRKulkarni SmitaRKulkarni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alesapin alesapin added this pull request to the merge queue Nov 12, 2025
Merged via the queue into master with commit 6f19022 Nov 12, 2025
127 of 130 checks passed
@alesapin alesapin deleted the show_catalogs_in_show_databses branch November 12, 2025 16:33
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 12, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 12, 2025
This was referenced Nov 12, 2025
Closed
Closed
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Nov 12, 2025
@robot-clickhouse
Backport #89914 to 25.10: Show datalake catalogs in SHOW DATABASES query
3ef5fb5
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 12, 2025
Merged
clickhouse-gh Bot added a commit that referenced this pull request Nov 12, 2025
@clickhouse-gh
Merge pull request #89953 from ClickHouse/backport/25.10/89914
76baf5d 
Backport #89914 to 25.10: Show datalake catalogs in SHOW DATABASES query
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Dec 8, 2025
@CarlosFelipeOR CarlosFelipeOR mentioned this pull request Dec 29, 2025
Closed
2 tasks
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Dec 29, 2025
@alesapin @zvonand
Merge pull request ClickHouse#89914 from ClickHouse/show_catalogs_in_…
463f081 
…show_databses

Show datalake catalogs in SHOW DATABASES query
@zvonand zvonand mentioned this pull request Dec 29, 2025
Merged
25 tasks
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Jan 6, 2026
@zvonand
Merge pull request #1266 from Altinity/backports/25.8.13/89914
5dcd319 
25.8.13 Backport of ClickHouse#89914 - Show datalake catalogs in SHOW DATABASES query
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 9, 2026
@clickhouse-gh @zvonand
Merge pull request ClickHouse#89953 from ClickHouse/backport/25.10/89914
2737263 
Backport ClickHouse#89914 to 25.10: Show datalake catalogs in SHOW DATABASES query
@zvonand zvonand mentioned this pull request Jan 9, 2026
Merged
25 tasks
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Jan 14, 2026
@zvonand
Merge pull request #1283 from Altinity/backports/antalya-25.8/89914
a3deda9 
Antalya 25.8 Backport of ClickHouse#89914: Show datalake catalogs in SHOW DATABASES query
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 14, 2026
@alesapin @zvonand
Merge pull request ClickHouse#89914 from ClickHouse/show_catalogs_in_…
a401b0c 
…show_databses

Show datalake catalogs in SHOW DATABASES query
@zvonand zvonand mentioned this pull request Jan 14, 2026
Closed
25 tasks
zvonand pushed a commit to Altinity/ClickHouse that referenced this pull request Jan 22, 2026
@alesapin @zvonand
Merge pull request ClickHouse#89914 from ClickHouse/show_catalogs_in_…
80a5008 
…show_databses

Show datalake catalogs in SHOW DATABASES query
@zvonand zvonand mentioned this pull request Jan 22, 2026
Merged
25 tasks
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Jan 27, 2026
@zvonand
Merge pull request #1331 from Altinity/backports/25.8.15/88341
c885402 
25.8.15 Stable backport of ClickHouse#88341, ClickHouse#89914
@alsugiliazova
Copy link
Copy Markdown
Contributor

alsugiliazova commented Apr 23, 2026 •
edited
Loading

DataLakeCatalog database is not shown in system.databases when show_data_lake_catalogs_in_system_tables is set to 0:

SET show_data_lake_catalogs_in_system_tables = 0

Query id: 326d7595-070c-4752-aa02-e0cf082f9d02

Ok.

0 rows in set. Elapsed: 0.001 sec. 


SHOW DATABASES

Query id: a4fe38d4-90de-44b0-ac35-310d4543ab15

   ┌─name──────────────────┐
1. │ INFORMATION_SCHEMA    │
2. │ default               │
3. │ iceberg_database_name │
4. │ information_schema    │
5. │ system                │
   └───────────────────────┘

5 rows in set. Elapsed: 0.001 sec. 



SELECT name
FROM system.databases

Query id: 6633b62a-8391-4474-ab97-400c38c7584a

   ┌─name───────────────┐
1. │ INFORMATION_SCHEMA │
2. │ default            │
3. │ information_schema │
4. │ system             │
   └────────────────────┘

4 rows in set. Elapsed: 0.001 sec.

@alsugiliazova alsugiliazova mentioned this pull request Apr 23, 2026
Merged
This was referenced Apr 24, 2026
Merged
Merged
zoomxi pushed a commit to zoomxi/ClickHouse that referenced this pull request Apr 27, 2026
@alsugiliazova
Fix: system.databases always shows data lake catalog databases
71cb441 
`system.databases` now lists data lake catalog databases regardless of
the `show_data_lake_catalogs_in_system_tables` setting.

The setting exists to prevent accidental expensive calls to remote
catalog services (e.g. listing tables or columns). Knowing that a
catalog database exists, however, requires no remote call — the
`DatabaseCatalog` already keeps it in local memory. Hiding the
database in `system.databases` based on that setting was inconsistent
with `SHOW DATABASES` (which always showed catalogs since ClickHouse#89914) and
confusing for users.

Changes:
- `StorageSystemDatabases::fillData` now passes
  `with_datalake_catalogs = true` unconditionally.
- `InterpreterShowTablesQuery::execute` no longer needs to force the
  setting for `SHOW DATABASES` (the rewrite to `system.databases`
  already returns the right result). The HACK is retained only for
  `SHOW TABLES FROM <datalake_catalog>` which still needs it.
- Updated `test_database_glue` integration test to assert that
  `system.databases` shows the catalog even with the setting off.

Followup to: ClickHouse#89914

Made-with: Cursor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SmitaRKulkarni SmitaRKulkarni SmitaRKulkarni approved these changes

Assignees

@SmitaRKulkarni SmitaRKulkarni

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alesapin @alsugiliazova @SmitaRKulkarni @mlex @nikitamikhaylov @robot-ch-test-poll3 @robot-clickhouse-ci-2