Backport #89850 to 25.9: Fix logical error with empty tuple inside IN function#89902
Merged
clickhouse-gh[bot] merged 2 commits into25.9from Nov 20, 2025
Merged
Backport #89850 to 25.9: Fix logical error with empty tuple inside IN function#89902clickhouse-gh[bot] merged 2 commits into25.9from
clickhouse-gh[bot] merged 2 commits into25.9from
Conversation
fe3b741 to
caa2fab
Compare
Contributor
|
Workflow [BackportPR], commit [74a998b] |
Member
|
@Avogar The the stateless test failure: 2025-11-11 22:14:44 Received exception from server (version 25.9.6):
2025-11-11 22:14:44 Code: 1. DB::Exception: Received from localhost:9000. DB::Exception: Function 'in' is supported only if second argument is constant or table expression. (UNSUPPORTED_METHOD)
2025-11-11 22:14:44 (query: SELECT CAST(tuple(), 'Tuple()') IN (tuple());)
2025-11-11 22:14:44 , result:
2025-11-11 22:14:44
2025-11-11 22:14:44
2025-11-11 22:14:44
2025-11-11 22:14:44 stdout:
2025-11-11 22:14:44
2025-11-11 22:14:44 It is only failing in 25.9, 25.8 and 25.3; but passing in 25.10. Seems like there is some backward compatibility issue with that query. Is it reasonable to remove the failing query from 25.9, 25.8 and 25.3 to fix it? |
Member
|
This change is missing on <25.10 versions: #87520 |
Member
|
@nihalzp I backported that fix, let's update these backports with latest commits from the corresponding version branch and run tests again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #89850
Cherry-pick pull-request #89901
This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.
The PR source
The PR is created in the CI job