Skip to content

Backport #89850 to 25.9: Fix logical error with empty tuple inside IN function#89902

Merged
clickhouse-gh[bot] merged 2 commits into25.9from
backport/25.9/89850
Nov 20, 2025
Merged

Backport #89850 to 25.9: Fix logical error with empty tuple inside IN function#89902
clickhouse-gh[bot] merged 2 commits into25.9from
backport/25.9/89850

Conversation

@robot-clickhouse
Copy link
Copy Markdown
Member

Original pull-request #89850
Cherry-pick pull-request #89901

This pull-request is a last step of an automated backporting.
Treat it as a standard pull-request: look at the checks and resolve conflicts.
Merge it only if you intend to backport changes to the target branch, otherwise just close it.

The PR source

The PR is created in the CI job

@robot-clickhouse robot-clickhouse added pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-critical-bugfix labels Nov 12, 2025
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 12, 2025

Workflow [BackportPR], commit [74a998b]

@nihalzp
Copy link
Copy Markdown
Member

nihalzp commented Nov 12, 2025

@Avogar The the stateless test failure:

2025-11-11 22:14:44 Received exception from server (version 25.9.6):
2025-11-11 22:14:44 Code: 1. DB::Exception: Received from localhost:9000. DB::Exception: Function 'in' is supported only if second argument is constant or table expression. (UNSUPPORTED_METHOD)
2025-11-11 22:14:44 (query: SELECT CAST(tuple(), 'Tuple()') IN (tuple());)
2025-11-11 22:14:44 , result:
2025-11-11 22:14:44 
2025-11-11 22:14:44 
2025-11-11 22:14:44 
2025-11-11 22:14:44 stdout:
2025-11-11 22:14:44 
2025-11-11 22:14:44 

It is only failing in 25.9, 25.8 and 25.3; but passing in 25.10. Seems like there is some backward compatibility issue with that query. Is it reasonable to remove the failing query from 25.9, 25.8 and 25.3 to fix it?

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Nov 13, 2025

This change is missing on <25.10 versions: #87520
Without this change tuple() returns non-constant column. Let's backport it first

@Avogar
Copy link
Copy Markdown
Member

Avogar commented Nov 19, 2025

@nihalzp I backported that fix, let's update these backports with latest commits from the corresponding version branch and run tests again

@clickhouse-gh clickhouse-gh bot merged commit 7b5bd02 into 25.9 Nov 20, 2025
64 of 66 checks passed
@clickhouse-gh clickhouse-gh bot deleted the backport/25.9/89850 branch November 20, 2025 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backport Changes, backported to release branch. Do not use manually - automated use only! pr-critical-bugfix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants