Skip to content

Fix creating an array of empty tuples#87520

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Avogar:fix-array-of-empty-tuples
Sep 29, 2025
Merged

Fix creating an array of empty tuples#87520
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
Avogar:fix-array-of-empty-tuples

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Sep 23, 2025 •
edited
Loading

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix creating an array of empty tuples

Closes #86642

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Sep 23, 2025 •
edited
Loading

Workflow [PR], commit [de44e51]

Summary: ❌

job_name test_name status info comment
Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) failure
03310_materialized_view_with_bad_select FAIL
Exception in test runner FAIL
Killed by signal (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Fatal messages (in clickhouse-server.log or clickhouse-server.err.log) FAIL
Integration tests (arm_binary, distributed plan, 1/4) failure
test_merge_tree_s3/test.py::test_simple_insert_select[0-17-node] FAIL
test_merge_tree_s3/test.py::test_insert_same_partition_and_merge[False-node] FAIL
test_merge_tree_s3/test.py::test_move_partition_to_another_disk[node] FAIL
test_merge_tree_s3/test.py::test_cache_with_full_disk_space[node_with_limited_disk] FAIL
test_merge_tree_s3/test.py::test_s3_engine_heavy_write_check_mem[in_flight_memory0-node] FAIL
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3] FAIL
test_merge_tree_s3/test.py::test_simple_insert_select[8192-13-node] FAIL
test_merge_tree_s3/test.py::test_move_replace_partition_to_another_table[node] FAIL
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors_when_move[node] FAIL
test_merge_tree_s3/test.py::test_lazy_seek_optimization_for_async_read[node] FAIL
test_merge_tree_s3/test.py::test_freeze_system_unfreeze[node] FAIL
test_merge_tree_s3/test.py::test_insert_same_partition_and_merge[True-node] FAIL
test_merge_tree_s3/test.py::test_merge_canceled_by_s3_errors[node-broken_s3_always_multi_part] FAIL
test_merge_tree_s3/test.py::test_metadata_path_works_correctly[node] FAIL
test_merge_tree_s3/test.py::test_s3_disk_reads_on_unstable_connection[node] FAIL
test_merge_tree_s3/test.py::test_merge_canceled_by_drop[node] FAIL
test_merge_tree_s3/test.py::test_s3_disk_apply_new_settings[node] FAIL
test_merge_tree_s3/test.py::test_s3_engine_heavy_write_check_mem[in_flight_memory2-node] FAIL
test_merge_tree_s3/test.py::test_table_manipulations[node] FAIL
test_merge_tree_s3/test.py::test_freeze_unfreeze[node] FAIL
test_merge_tree_s3/test.py::test_s3_no_delete_objects[node] FAIL
test_merge_tree_s3/test.py::test_attach_detach_partition[node] FAIL
test_merge_tree_s3/test.py::test_alter_table_columns[node] FAIL
test_merge_tree_s3/test.py::test_s3_engine_heavy_write_check_mem[in_flight_memory1-node] FAIL
test_merge_tree_s3/test.py::test_s3_disk_heavy_write_check_mem[node] FAIL
Stress test (amd_tsan) failure
Stress test (amd_msan) failure
Server died FAIL
Hung check failed, possible deadlock found (see hung_check.log) FAIL
Killed by signal (in clickhouse-server.log) FAIL
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL
Killed by signal (output files) FAIL
Found signal in gdb.log FAIL

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Sep 23, 2025
@evillique evillique self-assigned this Sep 23, 2025
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Sep 29, 2025

Stateless tests (amd_binary, ParallelReplicas, s3 storage, parallel) - #87653
Integration tests (arm_binary, distributed plan, 1/4) - problems with docker registry
Stress test (amd_tsan) and Stress test (amd_msan) - #87653

@alexey-milovidov alexey-milovidov merged commit 4a99010 into ClickHouse:master Sep 29, 2025
230 of 242 checks passed
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Sep 29, 2025

@alexey-milovidov CH Inc sync check was not finished, there were problems with integration tests in the sync PR that are related to the changes. I made a fix in the sync and was waiting for the integration tests to finish to check if everything is correct, but now sync is merged without finished integration tests. Please, next time let's wait for tests in sync to finish in such cases.

@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Sep 29, 2025
@Avogar Avogar mentioned this pull request Nov 13, 2025
Merged
@Avogar Avogar added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 13, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 13, 2025
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 13, 2025
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Nov 13, 2025
@robot-clickhouse-ci-2
Merge pull request #89988 from ClickHouse/cherrypick/25.3/87520
51ef8dd 
Cherry pick #87520 to 25.3: Fix creating an array of empty tuples
robot-clickhouse added a commit that referenced this pull request Nov 13, 2025
@robot-clickhouse
Backport #87520 to 25.3: Fix creating an array of empty tuples
1e46fd7
This was referenced Nov 13, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Nov 13, 2025
@robot-clickhouse-ci-2
Merge pull request #89990 from ClickHouse/cherrypick/25.8/87520
709710b 
Cherry pick #87520 to 25.8: Fix creating an array of empty tuples
robot-clickhouse added a commit that referenced this pull request Nov 13, 2025
@robot-clickhouse
Backport #87520 to 25.8: Fix creating an array of empty tuples
755fc1e
This was referenced Nov 13, 2025
Merged
Merged
robot-clickhouse-ci-2 added a commit that referenced this pull request Nov 13, 2025
@robot-clickhouse-ci-2
Merge pull request #89992 from ClickHouse/cherrypick/25.9/87520
13de568 
Cherry pick #87520 to 25.9: Fix creating an array of empty tuples
robot-clickhouse added a commit that referenced this pull request Nov 13, 2025
@robot-clickhouse
Backport #87520 to 25.9: Fix creating an array of empty tuples
8694e22
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 mentioned this pull request Nov 13, 2025
Merged
@robot-clickhouse-ci-1 robot-clickhouse-ci-1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 13, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 13, 2025
@clickhouse-gh
Merge pull request #89993 from ClickHouse/backport/25.9/87520
38d3dc6 
Backport #87520 to 25.9: Fix creating an array of empty tuples
Avogar added a commit that referenced this pull request Nov 17, 2025
@Avogar
Merge pull request #89991 from ClickHouse/backport/25.8/87520
f9a995b 
Backport #87520 to 25.8: Fix creating an array of empty tuples
Avogar added a commit that referenced this pull request Nov 17, 2025
@Avogar
Merge pull request #89989 from ClickHouse/backport/25.3/87520
486ab25 
Backport #87520 to 25.3: Fix creating an array of empty tuples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

@evillique evillique evillique approved these changes

Assignees

@evillique evillique

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[CI crash] ColumnArray conversion failed in ArrayJoin

6 participants

@Avogar @alexey-milovidov @evillique @robot-ch-test-poll1 @robot-ch-test-poll2 @robot-clickhouse-ci-1