Skip to content

Fix reading paths and paths subcolumns from advanced shared data serialization#89819

Merged
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fix-advanced-shared-data
Nov 11, 2025
Merged

Fix reading paths and paths subcolumns from advanced shared data serialization#89819
Avogar merged 2 commits intoClickHouse:masterfrom
Avogar:fix-advanced-shared-data

Conversation

@Avogar
Copy link
Copy Markdown
Member

@Avogar Avogar commented Nov 10, 2025 •
edited
Loading

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Fix possible logical error during reading of paths and their subcolumns in advanced JSON shared data serialization. Closes #89805

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 10, 2025 •
edited
Loading

Workflow [PR], commit [53be9fb]

Summary: ❌

job_name test_name status info comment
Integration tests (arm_binary, distributed plan, 4/4) failure
test_dictionaries_dependency_xml/test.py::test_get_data FAIL cidb
Upgrade check (amd_asan) failure
Killed by signal (in clickhouse-server.log) FAIL cidb
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL cidb
Killed by signal (output files) FAIL cidb
Found signal in gdb.log FAIL cidb
Upgrade check (amd_tsan) failure
Killed by signal (in clickhouse-server.log) FAIL cidb
Fatal message in clickhouse-server.log (see fatal_messages.txt) FAIL cidb
Killed by signal (output files) FAIL cidb
Found signal in gdb.log FAIL cidb

@clickhouse-gh clickhouse-gh bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Nov 10, 2025
@Avogar
Copy link
Copy Markdown
Member Author

Avogar commented Nov 11, 2025 •
edited
Loading

Upgrade check (amd_asan) - #89834
Upgrade check (amd_tsan) - #89220
Integration tests (arm_binary, distributed plan, 4/4) - #89852

@antonio2368 antonio2368 self-assigned this Nov 11, 2025
@Avogar Avogar changed the title Fix reading paths and paths subcolumns from advanced shared data seri… Fix reading paths and paths subcolumns from advanced shared data serialization Nov 11, 2025
@Avogar Avogar added this pull request to the merge queue Nov 11, 2025
Merged via the queue into ClickHouse:master with commit 6f9c359 Nov 11, 2025
250 of 258 checks passed
@Avogar Avogar deleted the fix-advanced-shared-data branch November 11, 2025 13:48
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 11, 2025
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 11, 2025
This was referenced Nov 11, 2025
Closed
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Nov 11, 2025
@robot-ch-test-poll3
Merge pull request #89856 from ClickHouse/cherrypick/25.8/89819
c590fb4 
Cherry pick #89819 to 25.8: Fix reading paths and paths subcolumns from advanced shared data serialization
robot-clickhouse added a commit that referenced this pull request Nov 11, 2025
@robot-clickhouse
Backport #89819 to 25.8: Fix reading paths and paths subcolumns from …
d6cf2af 
…advanced shared data serialization
This was referenced Nov 11, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Nov 11, 2025
@robot-ch-test-poll3
Merge pull request #89858 from ClickHouse/cherrypick/25.9/89819
1d6e5ac 
Cherry pick #89819 to 25.9: Fix reading paths and paths subcolumns from advanced shared data serialization
robot-clickhouse added a commit that referenced this pull request Nov 11, 2025
@robot-clickhouse
Backport #89819 to 25.9: Fix reading paths and paths subcolumns from …
dec6392 
…advanced shared data serialization
This was referenced Nov 11, 2025
Merged
Merged
robot-ch-test-poll3 added a commit that referenced this pull request Nov 11, 2025
@robot-ch-test-poll3
Merge pull request #89860 from ClickHouse/cherrypick/25.10/89819
c17ff8e 
Cherry pick #89819 to 25.10: Fix reading paths and paths subcolumns from advanced shared data serialization
robot-clickhouse added a commit that referenced this pull request Nov 11, 2025
@robot-clickhouse
Backport #89819 to 25.10: Fix reading paths and paths subcolumns from…
14d7933 
… advanced shared data serialization
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Nov 11, 2025
Merged
clickhouse-gh bot added a commit that referenced this pull request Nov 11, 2025
@clickhouse-gh
Merge pull request #89861 from ClickHouse/backport/25.10/89819
4186c75 
Backport #89819 to 25.10: Fix reading paths and paths subcolumns from advanced shared data serialization
@robot-ch-test-poll robot-ch-test-poll added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 11, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 11, 2025
@clickhouse-gh
Merge pull request #89859 from ClickHouse/backport/25.9/89819
b1fe0c6 
Backport #89819 to 25.9: Fix reading paths and paths subcolumns from advanced shared data serialization
@Algunenano Algunenano mentioned this pull request Nov 12, 2025
Closed
Avogar added a commit that referenced this pull request Nov 13, 2025
@Avogar
Merge pull request #89857 from ClickHouse/backport/25.8/89819
d63f45b 
Backport #89819 to 25.8: Fix reading paths and paths subcolumns from advanced shared data serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonio2368 antonio2368 antonio2368 approved these changes

Assignees

@antonio2368 antonio2368

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Logical error: Expected reading a single granule with X rows, requested Y rows in Compact part in bucket Z

5 participants

@Avogar @antonio2368 @robot-ch-test-poll @robot-ch-test-poll4 @robot-ch-test-poll3