Skip to content

Add runtime filters only for supported join algorithms#89652

Merged
davenger merged 2 commits intomasterfrom
fix_rt_filter_and_nonhashjoin
Nov 6, 2025
Merged

Add runtime filters only for supported join algorithms#89652
davenger merged 2 commits intomasterfrom
fix_rt_filter_and_nonhashjoin

Conversation

@davenger
Copy link
Copy Markdown
Member

@davenger davenger commented Nov 6, 2025

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Add runtime filters only for supported join algorithms i.e. hash joins. A filter can only be built when join algorithm first fully reads the right side and then reads the left side, but FullSortingMergeJoin for example reads both sides simultaneously. Fixes #89220

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

Resolves #89220

@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Nov 6, 2025

Workflow [PR], commit [0d762d0]

Summary:

@clickhouse-gh clickhouse-gh bot added the pr-bugfix Pull request with bugfix, not backported by default label Nov 6, 2025
@davenger davenger added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Nov 6, 2025
@antaljanosbenjamin antaljanosbenjamin self-assigned this Nov 6, 2025
@davenger davenger added this pull request to the merge queue Nov 6, 2025
Merged via the queue into master with commit 9f4baa5 Nov 6, 2025
131 checks passed
@davenger davenger deleted the fix_rt_filter_and_nonhashjoin branch November 6, 2025 20:50
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 6, 2025
@robot-clickhouse robot-clickhouse added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Nov 6, 2025
robot-ch-test-poll2 added a commit that referenced this pull request Nov 6, 2025
Cherry pick #89652 to 25.10: Add runtime filters only for supported join algorithms
robot-clickhouse added a commit that referenced this pull request Nov 6, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Nov 6, 2025
clickhouse-gh bot added a commit that referenced this pull request Nov 6, 2025
Backport #89652 to 25.10: Add runtime filters only for supported join algorithms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical error: Trying to insert into runtime filter after it was marked as finished

5 participants